From 72b3fbc7b5b5bbe783ca6a6b14532770f6eb011d Mon Sep 17 00:00:00 2001 From: drh Date: Tue, 19 Jun 2012 03:11:25 +0000 Subject: [PATCH 1/5] Improved accuracy on text-to-real and real-to-text conversions. Most conversions now round-trip correctly. Still need to fix some corner cases. FossilOrigin-Name: 8ecffca900cd6a8922001fd458a266ce8c83fb66 --- manifest | 21 ++++++++++++--------- manifest.uuid | 2 +- src/func.c | 13 ++++++++++++- src/printf.c | 15 +++++++++------ test/atof1.test | 32 ++++++++++++++++++++++++++++---- test/date.test | 2 +- 6 files changed, 63 insertions(+), 22 deletions(-) diff --git a/manifest b/manifest index 9606896e10..92463ef29e 100644 --- a/manifest +++ b/manifest @@ -1,5 +1,5 @@ -C Improved\srounding\saccuracy\son\stest-to-float\sconversions. -D 2012-06-19T00:45:16.776 +C Improved\saccuracy\son\stext-to-real\sand\sreal-to-text\sconversions.\s\sMost\nconversions\snow\sround-trip\scorrectly.\s\sStill\sneed\sto\sfix\ssome\scorner\ncases. +D 2012-06-19T03:11:25.621 F Makefile.arm-wince-mingw32ce-gcc d6df77f1f48d690bd73162294bbba7f59507c72f F Makefile.in d17fddaa4e81f93a7c9c7c0808aacb3fc95f79f4 F Makefile.linux-gcc 91d710bdc4998cb015f39edf3cb314ec4f4d7e23 @@ -135,7 +135,7 @@ F src/delete.c 4c20ea4f6213b3bc1c6a510586864b679946e05e F src/expr.c 06a7733d19dc725dc46ba51afd9feadb4b85d991 F src/fault.c 160a0c015b6c2629d3899ed2daf63d75754a32bb F src/fkey.c 657212460bf5cfd3ae607d12ea62092844c227b5 -F src/func.c c6b3c94320253a35bda43fb69cc292618e3285d6 +F src/func.c 22a180ac02e725a16aed586c3ae1c1c0f7c79cfd F src/global.c 4cfdca5cb0edd33c4d021baec4ede958cb2c793b F src/hash.c 458488dcc159c301b8e7686280ab209f1fb915af F src/hash.h 2894c932d84d9f892d4b4023a75e501f83050970 @@ -174,7 +174,7 @@ F src/pcache.h 1b5dcc3dc8103d03e625b177023ee67764fa6b7c F src/pcache1.c 2234d84f9c003d800a57f00f8535c91667fa4f6c F src/pragma.c eee3e3161f82a1e06f632a8d2a82b29ba3c45889 F src/prepare.c 33291b83cca285718048d219c67b8298501fa3a5 -F src/printf.c 7ffb4ebb8b341f67e049695ba031da717b3d2699 +F src/printf.c 263748c3b1e41f9f16a567ef2cbe4cf95b897a1a F src/random.c cd4a67b3953b88019f8cd4ccd81394a8ddfaba50 F src/resolve.c b3c70ab28cac60de33684c9aa9e5138dcf71d6dd F src/rowset.c f6a49f3e9579428024662f6e2931832511f831a1 @@ -274,7 +274,7 @@ F test/async2.test c0a9bd20816d7d6a2ceca7b8c03d3d69c28ffb8b F test/async3.test d73a062002376d7edc1fe3edff493edbec1fc2f7 F test/async4.test 1787e3952128aa10238bf39945126de7ca23685a F test/async5.test 0dd8701bd588bf6e70c2557a22ae3f22b2567b4c -F test/atof1.test 1f6dc0f47f6697e32fa51dd154412e1172984928 +F test/atof1.test 6e6d41337133cb98e61262fa385780e04e9de165 F test/attach.test 0d112b7713611fdf0340260192749737135fda5f F test/attach2.test e54436ed956d3d88bdee61221da59bf3935a0966 F test/attach3.test d89ccfe4fe6e2b5e368d480fcdfe4b496c54cf4e @@ -364,7 +364,7 @@ F test/crashtest1.c 09c1c7d728ccf4feb9e481671e29dda5669bbcc2 F test/createtab.test b5de160630b209c4b8925bdcbbaf48cc90b67fe8 F test/cse.test 277350a26264495e86b1785f34d2d0c8600e021c F test/ctime.test 7bd009071e242aac4f18521581536b652b789a47 -F test/date.test a18a2ce81add84b17b06559e82ad7bb91bc6ddff +F test/date.test f3228180c87bbe5d39c9397bf001c0095c3821b9 F test/dbstatus.test 207e5b63fcb7b9c3bb8e1fdf38ebd4654ad0e54b F test/dbstatus2.test b1de8250fde1f3474d6b86f0e89de38d84794f56 F test/default.test 6faf23ccb300114924353007795aa9a8ec0aa9dc @@ -1006,7 +1006,10 @@ F tool/tostr.awk e75472c2f98dd76e06b8c9c1367f4ab07e122d06 F tool/vdbe-compress.tcl d70ea6d8a19e3571d7ab8c9b75cba86d1173ff0f F tool/warnings-clang.sh f6aa929dc20ef1f856af04a730772f59283631d4 F tool/warnings.sh fbc018d67fd7395f440c28f33ef0f94420226381 -P 892b74116a3b23268895b96433d18ef00c1433d8 -R f92cf3b5f19c2cdf0a1f4043259e76e0 +P 699b792c6a0e989994549959b11ec1bfad8bbd92 +R 9adb61fbfc8a4b0255b08c19fe781f44 +T *branch * floating-point-conversions +T *sym-floating-point-conversions * +T -sym-trunk * U drh -Z 37917877b4f7a2aac8f4f47ec8031274 +Z 93861bbc3afe941842927198b8f68ac0 diff --git a/manifest.uuid b/manifest.uuid index 9a76fd8178..630caf4294 100644 --- a/manifest.uuid +++ b/manifest.uuid @@ -1 +1 @@ -699b792c6a0e989994549959b11ec1bfad8bbd92 \ No newline at end of file +8ecffca900cd6a8922001fd458a266ce8c83fb66 \ No newline at end of file diff --git a/src/func.c b/src/func.c index 6ffc7184b0..7aaef2b38f 100644 --- a/src/func.c +++ b/src/func.c @@ -863,8 +863,19 @@ static void quoteFunc(sqlite3_context *context, int argc, sqlite3_value **argv){ assert( argc==1 ); UNUSED_PARAMETER(argc); switch( sqlite3_value_type(argv[0]) ){ - case SQLITE_INTEGER: case SQLITE_FLOAT: { + double r1, r2; + r1 = sqlite3_value_double(argv[0]); + char zBuf[50]; + sqlite3_snprintf(sizeof(zBuf), zBuf, "%!.15g", r1); + sqlite3AtoF(zBuf, &r2, 20, SQLITE_UTF8); + if( r1!=r2 ){ + sqlite3_snprintf(sizeof(zBuf), zBuf, "%!.20e", r1); + } + sqlite3_result_text(context, zBuf, -1, SQLITE_TRANSIENT); + break; + } + case SQLITE_INTEGER: { sqlite3_result_value(context, argv[0]); break; } diff --git a/src/printf.c b/src/printf.c index 58cfd2bd41..75febb286f 100644 --- a/src/printf.c +++ b/src/printf.c @@ -124,7 +124,8 @@ static const et_info fmtinfo[] = { static char et_getdigit(LONGDOUBLE_TYPE *val, int *cnt){ int digit; LONGDOUBLE_TYPE d; - if( (*cnt)++ >= 16 ) return '0'; + if( (*cnt)<=0 ) return '0'; + (*cnt)--; digit = (int)*val; d = digit; digit += '0'; @@ -428,9 +429,11 @@ void sqlite3VXPrintf( break; } if( realvalue>0.0 ){ - while( realvalue>=1e32 && exp<=350 ){ realvalue *= 1e-32; exp+=32; } - while( realvalue>=1e8 && exp<=350 ){ realvalue *= 1e-8; exp+=8; } - while( realvalue>=10.0 && exp<=350 ){ realvalue *= 0.1; exp++; } + LONGDOUBLE_TYPE scale = 1.0; + while( realvalue>=1e64*scale && exp<=350 ){ scale *= 1e64; exp+=64; } + while( realvalue>=1e8*scale && exp<=350 ){ scale *= 1e8; exp+=8; } + while( realvalue>=10.0*scale && exp<=350 ){ scale *= 10.0; exp++; } + realvalue /= scale; while( realvalue<1e-8 ){ realvalue *= 1e8; exp-=8; } while( realvalue<1.0 ){ realvalue *= 10.0; exp--; } if( exp>350 ){ @@ -463,7 +466,7 @@ void sqlite3VXPrintf( xtype = etFLOAT; } }else{ - flag_rtz = 0; + flag_rtz = flag_altform2; } if( xtype==etEXP ){ e2 = 0; @@ -478,7 +481,7 @@ void sqlite3VXPrintf( } } zOut = bufpt; - nsd = 0; + nsd = 16 + flag_altform2*10; flag_dp = (precision>0 ?1:0) | flag_alternateform | flag_altform2; /* The sign in front of the number */ if( prefix ){ diff --git a/test/atof1.test b/test/atof1.test index dff5e2a3d8..f1635789a6 100644 --- a/test/atof1.test +++ b/test/atof1.test @@ -17,10 +17,14 @@ source $testdir/tester.tcl expr srand(1) for {set i 1} {$i<10000} {incr i} { - do_test 1.$i { - set pow [expr {int((rand()-0.5)*100)}] - set x [expr {pow((rand()-0.5)*2*rand(),$pow)}] - set xf [format %.45e $x] + set pow [expr {int((rand()-0.5)*100)}] + set x [expr {pow((rand()-0.5)*2*rand(),$pow)}] + set xf [format %.32e $x] + + # Verify that text->real conversions get exactly same ieee754 floating- + # point value in SQLite as they do in TCL. + # + do_test 1.$i.1 { set y [db eval "SELECT $xf=\$x"] if {!$y} { puts -nonewline \173[db eval "SELECT real2hex($xf), real2hex(\$x)"]\175 @@ -30,6 +34,26 @@ for {set i 1} {$i<10000} {incr i} { } set y } {1} + + # FIX ME. The following tests (real->text->real round-trips) sometimes + # fail for large floating-point values. Skip them for now... + # + if {abs($x)>1e50} continue + + # Verify that round-trip real->text->real conversions using the quote() + # function preserve the bits of the numeric value exactly. + # + do_test 1.$i.2 { + set y [db eval {SELECT $x=CAST(quote($x) AS real)}] + if {!$y} { + db eval {SELECT real2hex($x) a, real2hex(CAST(quote($x) AS real)) b} {} + puts "\nIN: $a $xf" + puts [format {QUOTE: %16s %s} {} [db eval {SELECT quote($x)}]] + db eval {SELECT CAST(quote($x) AS real) c} {} + puts "OUT: $b [format %.32e $c]" + } + set y + } {1} } diff --git a/test/date.test b/test/date.test index 9bfec12626..a30402c0d6 100644 --- a/test/date.test +++ b/test/date.test @@ -151,7 +151,7 @@ datetest 3.2.1 {strftime('pre%fpost','2003-10-31 12:34:56.432')} pre56.432post datetest 3.2.2 {strftime('%f','2003-10-31 12:34:59.9999999')} 59.999 datetest 3.3 {strftime('%H','2003-10-31 12:34:56.432')} 12 datetest 3.4 {strftime('%j','2003-10-31 12:34:56.432')} 304 -datetest 3.5 {strftime('%J','2003-10-31 12:34:56.432')} 2452944.02426426 +datetest 3.5 {strftime('%J','2003-10-31 12:34:56.432')} 2452944.024264259 datetest 3.6 {strftime('%m','2003-10-31 12:34:56.432')} 10 datetest 3.7 {strftime('%M','2003-10-31 12:34:56.432')} 34 datetest 3.8.1 {strftime('%s','2003-10-31 12:34:56.432')} 1067603696 From 4ef941302867706bd6e997b9b46d5e096d93273e Mon Sep 17 00:00:00 2001 From: drh Date: Tue, 19 Jun 2012 03:35:05 +0000 Subject: [PATCH 2/5] Round-trip conversions of real->text->real are now lossless on x64 with GCC. Untested on other platforms so far. Still a corner-case problem with round(). FossilOrigin-Name: fd7bd4a59361be41b10522abc212cf56fb5e35b4 --- manifest | 17 +++++++---------- manifest.uuid | 2 +- src/printf.c | 1 + test/atof1.test | 7 +------ 4 files changed, 10 insertions(+), 17 deletions(-) diff --git a/manifest b/manifest index 92463ef29e..f2fa197301 100644 --- a/manifest +++ b/manifest @@ -1,5 +1,5 @@ -C Improved\saccuracy\son\stext-to-real\sand\sreal-to-text\sconversions.\s\sMost\nconversions\snow\sround-trip\scorrectly.\s\sStill\sneed\sto\sfix\ssome\scorner\ncases. -D 2012-06-19T03:11:25.621 +C Round-trip\sconversions\sof\sreal->text->real\sare\snow\slossless\son\sx64\swith\sGCC.\nUntested\son\sother\splatforms\sso\sfar.\s\sStill\sa\scorner-case\sproblem\swith\sround(). +D 2012-06-19T03:35:05.368 F Makefile.arm-wince-mingw32ce-gcc d6df77f1f48d690bd73162294bbba7f59507c72f F Makefile.in d17fddaa4e81f93a7c9c7c0808aacb3fc95f79f4 F Makefile.linux-gcc 91d710bdc4998cb015f39edf3cb314ec4f4d7e23 @@ -174,7 +174,7 @@ F src/pcache.h 1b5dcc3dc8103d03e625b177023ee67764fa6b7c F src/pcache1.c 2234d84f9c003d800a57f00f8535c91667fa4f6c F src/pragma.c eee3e3161f82a1e06f632a8d2a82b29ba3c45889 F src/prepare.c 33291b83cca285718048d219c67b8298501fa3a5 -F src/printf.c 263748c3b1e41f9f16a567ef2cbe4cf95b897a1a +F src/printf.c 4a9f882f1c1787a8b494a2987765acf9d97ac21f F src/random.c cd4a67b3953b88019f8cd4ccd81394a8ddfaba50 F src/resolve.c b3c70ab28cac60de33684c9aa9e5138dcf71d6dd F src/rowset.c f6a49f3e9579428024662f6e2931832511f831a1 @@ -274,7 +274,7 @@ F test/async2.test c0a9bd20816d7d6a2ceca7b8c03d3d69c28ffb8b F test/async3.test d73a062002376d7edc1fe3edff493edbec1fc2f7 F test/async4.test 1787e3952128aa10238bf39945126de7ca23685a F test/async5.test 0dd8701bd588bf6e70c2557a22ae3f22b2567b4c -F test/atof1.test 6e6d41337133cb98e61262fa385780e04e9de165 +F test/atof1.test b765ba6bc09aa6a16234d2d66a71a5079f2a6d8a F test/attach.test 0d112b7713611fdf0340260192749737135fda5f F test/attach2.test e54436ed956d3d88bdee61221da59bf3935a0966 F test/attach3.test d89ccfe4fe6e2b5e368d480fcdfe4b496c54cf4e @@ -1006,10 +1006,7 @@ F tool/tostr.awk e75472c2f98dd76e06b8c9c1367f4ab07e122d06 F tool/vdbe-compress.tcl d70ea6d8a19e3571d7ab8c9b75cba86d1173ff0f F tool/warnings-clang.sh f6aa929dc20ef1f856af04a730772f59283631d4 F tool/warnings.sh fbc018d67fd7395f440c28f33ef0f94420226381 -P 699b792c6a0e989994549959b11ec1bfad8bbd92 -R 9adb61fbfc8a4b0255b08c19fe781f44 -T *branch * floating-point-conversions -T *sym-floating-point-conversions * -T -sym-trunk * +P 8ecffca900cd6a8922001fd458a266ce8c83fb66 +R 4b19672a1a06e137614a87d3123c24fd U drh -Z 93861bbc3afe941842927198b8f68ac0 +Z 1cc55456093d3d8044d88cb7bcd1bdba diff --git a/manifest.uuid b/manifest.uuid index 630caf4294..703abfa72b 100644 --- a/manifest.uuid +++ b/manifest.uuid @@ -1 +1 @@ -8ecffca900cd6a8922001fd458a266ce8c83fb66 \ No newline at end of file +fd7bd4a59361be41b10522abc212cf56fb5e35b4 \ No newline at end of file diff --git a/src/printf.c b/src/printf.c index 75febb286f..9f68d204ff 100644 --- a/src/printf.c +++ b/src/printf.c @@ -430,6 +430,7 @@ void sqlite3VXPrintf( } if( realvalue>0.0 ){ LONGDOUBLE_TYPE scale = 1.0; + while( realvalue>=1e100*scale && exp<=350 ){ scale *= 1e100;exp+=100;} while( realvalue>=1e64*scale && exp<=350 ){ scale *= 1e64; exp+=64; } while( realvalue>=1e8*scale && exp<=350 ){ scale *= 1e8; exp+=8; } while( realvalue>=10.0*scale && exp<=350 ){ scale *= 10.0; exp++; } diff --git a/test/atof1.test b/test/atof1.test index f1635789a6..66e1bee518 100644 --- a/test/atof1.test +++ b/test/atof1.test @@ -16,7 +16,7 @@ set testdir [file dirname $argv0] source $testdir/tester.tcl expr srand(1) -for {set i 1} {$i<10000} {incr i} { +for {set i 1} {$i<20000} {incr i} { set pow [expr {int((rand()-0.5)*100)}] set x [expr {pow((rand()-0.5)*2*rand(),$pow)}] set xf [format %.32e $x] @@ -35,11 +35,6 @@ for {set i 1} {$i<10000} {incr i} { set y } {1} - # FIX ME. The following tests (real->text->real round-trips) sometimes - # fail for large floating-point values. Skip them for now... - # - if {abs($x)>1e50} continue - # Verify that round-trip real->text->real conversions using the quote() # function preserve the bits of the numeric value exactly. # From 4aaf1552be2a1376bdc595077037e09f60adb691 Mon Sep 17 00:00:00 2001 From: drh Date: Tue, 19 Jun 2012 03:59:30 +0000 Subject: [PATCH 3/5] Fix an incorrect testcase for the round() function. All tests are passing now, including new real->text->real round-trip tests. FossilOrigin-Name: 963eb24f737f184d5fcdcd92ebf90466f818cfd8 --- manifest | 12 ++++++------ manifest.uuid | 2 +- test/func.test | 2 +- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/manifest b/manifest index f2fa197301..476505fb32 100644 --- a/manifest +++ b/manifest @@ -1,5 +1,5 @@ -C Round-trip\sconversions\sof\sreal->text->real\sare\snow\slossless\son\sx64\swith\sGCC.\nUntested\son\sother\splatforms\sso\sfar.\s\sStill\sa\scorner-case\sproblem\swith\sround(). -D 2012-06-19T03:35:05.368 +C Fix\san\sincorrect\stestcase\sfor\sthe\sround()\sfunction.\s\sAll\stests\sare\spassing\nnow,\sincluding\snew\sreal->text->real\sround-trip\stests. +D 2012-06-19T03:59:30.382 F Makefile.arm-wince-mingw32ce-gcc d6df77f1f48d690bd73162294bbba7f59507c72f F Makefile.in d17fddaa4e81f93a7c9c7c0808aacb3fc95f79f4 F Makefile.linux-gcc 91d710bdc4998cb015f39edf3cb314ec4f4d7e23 @@ -503,7 +503,7 @@ F test/fts4merge.test c424309743fdd203f8e56a1f1cd7872cd66cc0ee F test/fts4merge2.test 5faa558d1b672f82b847d2a337465fa745e46891 F test/fts4merge3.test aab02a09f50fe6baaddc2e159c3eabc116d45fc7 F test/fts4unicode.test 247e6c64563b5f930aec0f89a5b01ed6b4b129cd -F test/func.test 9809b7622d721904a8cc33c1ffb87f46d506ed01 +F test/func.test 0d89043dab9a8853358d14c68e028ee0093bf066 F test/func2.test 772d66227e4e6684b86053302e2d74a2500e1e0f F test/func3.test 001021e5b88bd02a3b365a5c5fd8f6f49d39744a F test/fuzz-oss1.test 4912e528ec9cf2f42134456933659d371c9e0d74 @@ -1006,7 +1006,7 @@ F tool/tostr.awk e75472c2f98dd76e06b8c9c1367f4ab07e122d06 F tool/vdbe-compress.tcl d70ea6d8a19e3571d7ab8c9b75cba86d1173ff0f F tool/warnings-clang.sh f6aa929dc20ef1f856af04a730772f59283631d4 F tool/warnings.sh fbc018d67fd7395f440c28f33ef0f94420226381 -P 8ecffca900cd6a8922001fd458a266ce8c83fb66 -R 4b19672a1a06e137614a87d3123c24fd +P fd7bd4a59361be41b10522abc212cf56fb5e35b4 +R c0c29fe1d0e93cd15c8e76222be12539 U drh -Z 1cc55456093d3d8044d88cb7bcd1bdba +Z 5bd3e2acf922536517e034479b86dc68 diff --git a/manifest.uuid b/manifest.uuid index 703abfa72b..eb04d6c81f 100644 --- a/manifest.uuid +++ b/manifest.uuid @@ -1 +1 @@ -fd7bd4a59361be41b10522abc212cf56fb5e35b4 \ No newline at end of file +963eb24f737f184d5fcdcd92ebf90466f818cfd8 \ No newline at end of file diff --git a/test/func.test b/test/func.test index ba1ea026d7..e44c44b280 100644 --- a/test/func.test +++ b/test/func.test @@ -312,7 +312,7 @@ ifcapable floatingpoint { execsql {SELECT round(9999999999999.55,1);} } {9999999999999.6} do_test func-4.38 { - execsql {SELECT round(9999999999999.555,2);} + execsql {SELECT round(9999999999999.556,2);} } {9999999999999.56} } From 2b434a7ec0b3bf9a04b581472439be02deb3e4cb Mon Sep 17 00:00:00 2001 From: mistachkin Date: Tue, 19 Jun 2012 04:36:48 +0000 Subject: [PATCH 4/5] Move variable declaration to fix compilation with MSVC. FossilOrigin-Name: d45f7a013f05fe7603d5e6d02df0e6bab2c7ffd8 --- manifest | 14 +++++++------- manifest.uuid | 2 +- src/func.c | 2 +- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/manifest b/manifest index 476505fb32..bd1f483817 100644 --- a/manifest +++ b/manifest @@ -1,5 +1,5 @@ -C Fix\san\sincorrect\stestcase\sfor\sthe\sround()\sfunction.\s\sAll\stests\sare\spassing\nnow,\sincluding\snew\sreal->text->real\sround-trip\stests. -D 2012-06-19T03:59:30.382 +C Move\svariable\sdeclaration\sto\sfix\scompilation\swith\sMSVC. +D 2012-06-19T04:36:48.907 F Makefile.arm-wince-mingw32ce-gcc d6df77f1f48d690bd73162294bbba7f59507c72f F Makefile.in d17fddaa4e81f93a7c9c7c0808aacb3fc95f79f4 F Makefile.linux-gcc 91d710bdc4998cb015f39edf3cb314ec4f4d7e23 @@ -135,7 +135,7 @@ F src/delete.c 4c20ea4f6213b3bc1c6a510586864b679946e05e F src/expr.c 06a7733d19dc725dc46ba51afd9feadb4b85d991 F src/fault.c 160a0c015b6c2629d3899ed2daf63d75754a32bb F src/fkey.c 657212460bf5cfd3ae607d12ea62092844c227b5 -F src/func.c 22a180ac02e725a16aed586c3ae1c1c0f7c79cfd +F src/func.c 18dfedfb857e100b05755a1b12e88b389f957879 F src/global.c 4cfdca5cb0edd33c4d021baec4ede958cb2c793b F src/hash.c 458488dcc159c301b8e7686280ab209f1fb915af F src/hash.h 2894c932d84d9f892d4b4023a75e501f83050970 @@ -1006,7 +1006,7 @@ F tool/tostr.awk e75472c2f98dd76e06b8c9c1367f4ab07e122d06 F tool/vdbe-compress.tcl d70ea6d8a19e3571d7ab8c9b75cba86d1173ff0f F tool/warnings-clang.sh f6aa929dc20ef1f856af04a730772f59283631d4 F tool/warnings.sh fbc018d67fd7395f440c28f33ef0f94420226381 -P fd7bd4a59361be41b10522abc212cf56fb5e35b4 -R c0c29fe1d0e93cd15c8e76222be12539 -U drh -Z 5bd3e2acf922536517e034479b86dc68 +P 963eb24f737f184d5fcdcd92ebf90466f818cfd8 +R f969ff33ef926829900ede45cb301833 +U mistachkin +Z 0dc9aadbc42938d9910cf216fa3f6f99 diff --git a/manifest.uuid b/manifest.uuid index eb04d6c81f..b28390f96e 100644 --- a/manifest.uuid +++ b/manifest.uuid @@ -1 +1 @@ -963eb24f737f184d5fcdcd92ebf90466f818cfd8 \ No newline at end of file +d45f7a013f05fe7603d5e6d02df0e6bab2c7ffd8 \ No newline at end of file diff --git a/src/func.c b/src/func.c index 7aaef2b38f..e56561e4ec 100644 --- a/src/func.c +++ b/src/func.c @@ -865,8 +865,8 @@ static void quoteFunc(sqlite3_context *context, int argc, sqlite3_value **argv){ switch( sqlite3_value_type(argv[0]) ){ case SQLITE_FLOAT: { double r1, r2; - r1 = sqlite3_value_double(argv[0]); char zBuf[50]; + r1 = sqlite3_value_double(argv[0]); sqlite3_snprintf(sizeof(zBuf), zBuf, "%!.15g", r1); sqlite3AtoF(zBuf, &r2, 20, SQLITE_UTF8); if( r1!=r2 ){ From c722a2c2e41554d9aa1027e55a608515b9909c12 Mon Sep 17 00:00:00 2001 From: drh Date: Thu, 21 Jun 2012 15:02:26 +0000 Subject: [PATCH 5/5] Disable the atof1.test module when compiling on MSVC. FossilOrigin-Name: 0f706acfc7181f2714a06b2c232677ebeede3a44 --- manifest | 16 ++++++++-------- manifest.uuid | 2 +- src/test_config.c | 15 +++++++++++++++ test/atof1.test | 9 +++++++-- 4 files changed, 31 insertions(+), 11 deletions(-) diff --git a/manifest b/manifest index bd1f483817..de8e9b1ae0 100644 --- a/manifest +++ b/manifest @@ -1,5 +1,5 @@ -C Move\svariable\sdeclaration\sto\sfix\scompilation\swith\sMSVC. -D 2012-06-19T04:36:48.907 +C Disable\sthe\satof1.test\smodule\swhen\scompiling\son\sMSVC. +D 2012-06-21T15:02:26.644 F Makefile.arm-wince-mingw32ce-gcc d6df77f1f48d690bd73162294bbba7f59507c72f F Makefile.in d17fddaa4e81f93a7c9c7c0808aacb3fc95f79f4 F Makefile.linux-gcc 91d710bdc4998cb015f39edf3cb314ec4f4d7e23 @@ -200,7 +200,7 @@ F src/test_async.c 0612a752896fad42d55c3999a5122af10dcf22ad F src/test_autoext.c 30e7bd98ab6d70a62bb9ba572e4c7df347fe645e F src/test_backup.c c129c91127e9b46e335715ae2e75756e25ba27de F src/test_btree.c 5b89601dcb42a33ba8b820a6b763cc9cb48bac16 -F src/test_config.c 4f7b8030287d62fe56a1d99e68b41760feae381a +F src/test_config.c 9b37587750f247186ebeb02a02e8f17c611d1866 F src/test_demovfs.c 20a4975127993f4959890016ae9ce5535a880094 F src/test_devsym.c e7498904e72ba7491d142d5c83b476c4e76993bc F src/test_func.c 3a8dd37c08ab43b76d38eea2836e34a3897bf170 @@ -274,7 +274,7 @@ F test/async2.test c0a9bd20816d7d6a2ceca7b8c03d3d69c28ffb8b F test/async3.test d73a062002376d7edc1fe3edff493edbec1fc2f7 F test/async4.test 1787e3952128aa10238bf39945126de7ca23685a F test/async5.test 0dd8701bd588bf6e70c2557a22ae3f22b2567b4c -F test/atof1.test b765ba6bc09aa6a16234d2d66a71a5079f2a6d8a +F test/atof1.test 9bf1d25180a2e05fc12ce3940cc8003033642f68 F test/attach.test 0d112b7713611fdf0340260192749737135fda5f F test/attach2.test e54436ed956d3d88bdee61221da59bf3935a0966 F test/attach3.test d89ccfe4fe6e2b5e368d480fcdfe4b496c54cf4e @@ -1006,7 +1006,7 @@ F tool/tostr.awk e75472c2f98dd76e06b8c9c1367f4ab07e122d06 F tool/vdbe-compress.tcl d70ea6d8a19e3571d7ab8c9b75cba86d1173ff0f F tool/warnings-clang.sh f6aa929dc20ef1f856af04a730772f59283631d4 F tool/warnings.sh fbc018d67fd7395f440c28f33ef0f94420226381 -P 963eb24f737f184d5fcdcd92ebf90466f818cfd8 -R f969ff33ef926829900ede45cb301833 -U mistachkin -Z 0dc9aadbc42938d9910cf216fa3f6f99 +P d45f7a013f05fe7603d5e6d02df0e6bab2c7ffd8 +R e35884badae6d1997ef669d538c5ea6c +U drh +Z 9a69b4050bef2b4e8b68607c50525e88 diff --git a/manifest.uuid b/manifest.uuid index b28390f96e..4a21353a92 100644 --- a/manifest.uuid +++ b/manifest.uuid @@ -1 +1 @@ -d45f7a013f05fe7603d5e6d02df0e6bab2c7ffd8 \ No newline at end of file +0f706acfc7181f2714a06b2c232677ebeede3a44 \ No newline at end of file diff --git a/src/test_config.c b/src/test_config.c index c04eb99a10..4f7dc64e5c 100644 --- a/src/test_config.c +++ b/src/test_config.c @@ -616,6 +616,21 @@ Tcl_SetVar2(interp, "sqlite_options", "long_double", Tcl_LinkVar(interp, "TEMP_STORE", (char *)&(cv_TEMP_STORE), TCL_LINK_INT | TCL_LINK_READ_ONLY); } + +#ifdef _MSC_VER + { + static const int cv__MSC_VER = 1; + Tcl_LinkVar(interp, "_MSC_VER", (char *)&(cv__MSC_VER), + TCL_LINK_INT | TCL_LINK_READ_ONLY); + } +#endif +#ifdef __GNUC__ + { + static const int cv___GNUC__ = 1; + Tcl_LinkVar(interp, "__GNUC__", (char *)&(cv___GNUC__), + TCL_LINK_INT | TCL_LINK_READ_ONLY); + } +#endif } diff --git a/test/atof1.test b/test/atof1.test index 66e1bee518..76eb4273b9 100644 --- a/test/atof1.test +++ b/test/atof1.test @@ -15,6 +15,11 @@ set testdir [file dirname $argv0] source $testdir/tester.tcl +if {![info exists __GNUC__]} { + finish_test + return +} + expr srand(1) for {set i 1} {$i<20000} {incr i} { set pow [expr {int((rand()-0.5)*100)}] @@ -24,7 +29,7 @@ for {set i 1} {$i<20000} {incr i} { # Verify that text->real conversions get exactly same ieee754 floating- # point value in SQLite as they do in TCL. # - do_test 1.$i.1 { + do_test atof1-1.$i.1 { set y [db eval "SELECT $xf=\$x"] if {!$y} { puts -nonewline \173[db eval "SELECT real2hex($xf), real2hex(\$x)"]\175 @@ -38,7 +43,7 @@ for {set i 1} {$i<20000} {incr i} { # Verify that round-trip real->text->real conversions using the quote() # function preserve the bits of the numeric value exactly. # - do_test 1.$i.2 { + do_test atof1-1.$i.2 { set y [db eval {SELECT $x=CAST(quote($x) AS real)}] if {!$y} { db eval {SELECT real2hex($x) a, real2hex(CAST(quote($x) AS real)) b} {}