132f96fc75
In the WhereClause object, do not assume that all TERM_VIRTUAL terms appear
...
at the end of the list, because that is no longer true. Instead, keep a
separate nBase count that is the size of the list excluding the tail of
virtual terms. Use nBase instead of nTerm when scanning terms that are not
virtual. Add assert()s to validate correctness of WhereClause.
FossilOrigin-Name: 6024682ca467fa4fe49608772b0bbfa2f8a419b32cebfa715941073c8b29da49
2021-12-08 16:07:22 +00:00
f6a4ef144e
Do not allow SQLITE_LIMIT_LENGTH to be set lower than 1 as an
...
SQLITE_LIMIT_LENGTH of 0 causes lots of unnecessary problems for
users of the sqlite3_str object.
FossilOrigin-Name: 8fd5b8ec4ab9b5554d27f25a4638d56e347eab78b60900f24b15a815d3731330
2021-12-06 15:40:24 +00:00
38ed1ceb5a
Do not allow certain dangerous ".testctrl" commands in safe mode.
...
FossilOrigin-Name: 080e72d119b836c49916201bf135445aa7d53cefe40a47437a93448c4d0f41cd
2021-12-06 15:24:36 +00:00
39addd0a3f
Fix SQLITE_TESTCTRL_IMPOSTER so that it is a harmless no-op if the schema
...
parameter is invalid.
FossilOrigin-Name: 2d9a45ab10aaad681e11d639195430c0988b6ca1b96db6bf0b31b889e88a5430
2021-12-06 15:08:30 +00:00
70b403b667
Factor the noop-join-elimination optimization out of the sqlite3WhereBegin()
...
routine and into a separate "no-inline" subroutine, in order to reduce the
complexity of sqlite3WhereBegin() and thereby encourage C compilers to
inline sqlite3WhereCodeOneLoopStart().
FossilOrigin-Name: 6225e9abcb0261fefca4a26530524ffc449f937f8ae1ece718af2c3c3d73d78d
2021-12-03 18:53:53 +00:00
60a8e1b43c
Fix exprAnalyze() after recent performance enhancements so that it is able
...
to handle IF_NULL_ROW opcode correctly, again.
FossilOrigin-Name: 8029e6bab508bf0b8ec1df00a829c5d4de2a84d66dc56b9ff03da879ceef7788
2021-12-03 15:48:42 +00:00
11e4fdb948
Fix unreachable branches resulting from prior optimizations.
...
FossilOrigin-Name: f3d6853ee80be2dc6d7236d98b850beb0e1931a624d4f5b194c8db742cde7ec5
2021-12-03 14:57:05 +00:00
fd4bf7746b
Fix an over-length source code line in build.c. No logic changes.
...
FossilOrigin-Name: b9db5c5fc618a36d70ea2aced9c96094d665935b5c15a987013334f1bd79eb00
2021-12-03 14:43:49 +00:00
2f0bc1d41b
Performance optimization in the B-Tree cursor allocator btreeCursor(), making
...
it about 800K CPU cycles faster in speedtest1, and reducing the executable
size by about 100 bytes.
FossilOrigin-Name: 9df939716ace8cfe60340bbe83fc52d452ea40c29c856c588f9a1b8973282391
2021-12-03 13:42:41 +00:00
65a3c8508d
Optimizations to exprAnalyze() and sqlite3WhereExprUsage() save about 1.5
...
million CPU cycles for speedtest1, and result in a smaller binary.
FossilOrigin-Name: 1f2252e65dc5847c82246fab87dcad035bf594ba7c45362de87a009b7ebcf2d6
2021-12-02 18:15:16 +00:00
daebb0f9a0
Move the TK_IS token so that it is adjacent to the TK_IN token, as this
...
allows the C compiler to optimize better, resulting in a slightly smaller
and faster executable.
FossilOrigin-Name: 8832fa9088414a8d285a457a4effad0b7d610a87ca73cfb5c5812e784649761e
2021-12-02 14:28:36 +00:00
1872c5bd43
In the shell tool, avoid modifying internal data structures until after the arguments to ".open" have been parsed.
...
FossilOrigin-Name: fcc509d325dabe06275e7804183bb8b4ba6470a45b443bc8292eecd0974e6367
2021-12-02 14:16:30 +00:00
cbb7746caa
Remove an unnecessary branch from exprAnalyze(), resulting in a small
...
performance gain.
FossilOrigin-Name: 3312be1db3519074393573265459f6a1eeabce541a9ef4d93689529ea2b8f739
2021-12-02 13:45:10 +00:00
cdd9050396
Small performance optimization in sqlite3WhereClauseClear().
...
FossilOrigin-Name: 080b35e62e5c6bb4ea162bc75232b81e54da5e3e01e762127e228400e8afef1d
2021-12-02 12:55:05 +00:00
844a89b518
More small performance optimizations for sqlite3WhereGetMask().
...
FossilOrigin-Name: 3de2c557d915d1b4a9b0e540d5e80ffb243e7123d0ec65c5052f4d6f1cce56b2
2021-12-02 12:34:05 +00:00
dae2a10934
Small performance optimization in sqlite3WhereGetMask().
...
FossilOrigin-Name: 7edec54ab045c0493fc5d27d47d7bf0e08d3b0b298f428646fd3f0ee24dfcade
2021-12-02 04:00:45 +00:00
79ab384121
Small performance enhancement for whereScanInit().
...
FossilOrigin-Name: ed84e124c6097b756ca687ac64df7ee801d14b16c835f1a9e8b336f785157d85
2021-12-02 02:22:35 +00:00
9b3bfa00cd
Performance improvement in query planning.
...
FossilOrigin-Name: ca59533bbb7f21d7b39dee7999d3f36ac516f8c75b2203039beeb2852ada42d4
2021-12-02 01:30:16 +00:00
3b26b2b56b
Check for foreign key constraint errors prior to returning the results from
...
a RETURNING clause. See [forum:/forumpost/793beaf322|forum post 793beaf322].
FossilOrigin-Name: a818ba2ed635b91e279dde44236fc7446a33db2b46c9409b67021248c01bf4e5
2021-12-01 19:17:14 +00:00
c1085ea412
In the automatic index generator logic, be more precise about when a
...
partial automatic index is allowed in order to capture more cases where it
is legal to use a partial automatic index.
FossilOrigin-Name: 664b461bb5063d98047fc2e51a3827235cd9f55ca2e23cb66e719eac53fb5437
2021-11-30 14:07:58 +00:00
1312a9c908
Add the unixepoch() function and the 'auto' and 'julianday' modifiers.
...
FossilOrigin-Name: 559fdc0aa76f4c207f99f7b0cee42043b402dc388165817529d9963b115a798c
2021-11-29 17:23:27 +00:00
6df8c0cd3b
Following a prior error, an ALWAYS() in sqlite3ExprCanBeNull() might be false.
...
dbsqlfuzz 5dbec6678a20e7595a34dfdd869a3b9722b3ca43.
FossilOrigin-Name: 4e207401acce1bdc17025f2d55bd94234b435e286cd43e1eda03b6949a2a91d3
2021-11-28 19:54:38 +00:00
14851b9a14
Fix a harmless comment typo.
...
FossilOrigin-Name: 7c567338ae4dd31097e9ae5c693b84369c35c5a52534797e8186b4be7297ba78
2021-11-27 12:03:51 +00:00
913306a53a
Improved defenses against integer overflow when computing the size of a
...
memory allocations. No bugs were fixed here. But perhaps future bugs will
be prevented.
FossilOrigin-Name: eb878c01f317f09e8ef6b1bd2ec8d6d5cd6ce0bdfe9da7fa7d92d2047cc9d9e4
2021-11-26 17:10:18 +00:00
e574a9233c
Fixes to internal comments. No changes to code or documentation.
...
FossilOrigin-Name: 1489b196ce82cddf7360aff6c89219ca25e666187f0f5ff6419ba3b504cdef8d
2021-11-26 15:08:55 +00:00
7907d372bc
Fix a compiler warning in the dbserialize method of the TCL interface.
...
FossilOrigin-Name: ba71d030fef4cd4251dc882acc6897dbf9aaba498652900c491b082add87404f
2021-11-23 12:59:25 +00:00
9f9bdf9345
Fix the build for SQLITE_OMIT_CTE.
...
FossilOrigin-Name: d7ef96bae459f800241483fe8784552d18ee7f92f408f6453ac687de5530bbb9
2021-11-22 13:35:40 +00:00
a51e60079f
Small performance increase and size reduction for sqlite3ExprCompare().
...
This change also handles some corner cases without the need for ALWAYS().
FossilOrigin-Name: d814ba6effc7c5b021ff625b57371627f3ee326687c508da99f78bc164386b7e
2021-11-19 19:11:58 +00:00
d9137e3be0
Fix a benign data race in os_unix.c that might trouble tsan and similar tools.
...
FossilOrigin-Name: 95806ac1dabe4598170061d903ae30f09bafac149ff6696963a7e056ac846cdb
2021-11-19 14:02:43 +00:00
5e90794b67
Minor tweaks to the way auxiliary tools are built, to make it easier to
...
customize the builds without having to alter the code.
FossilOrigin-Name: 90b06b6f42918852cfb15258be462c6bed260c6a618b86fa9084bac72fa2f58f
2021-11-18 20:56:59 +00:00
9cd0c3d4c5
Improve CSV quoting in the CLI using the strstr() function.
...
FossilOrigin-Name: b7927bf91049c903730a280484bbcdcdedc259a31fbcc3d3b0c7d046ec321633
2021-11-18 15:40:05 +00:00
e41d30ffdd
Fix an obscure problem associated with quoting of CSV output in the CLI.
...
FossilOrigin-Name: 38a9b660214c06aa6650c6bb11a429a8c74c09f1e0e5c18d691e36de4af7af71
2021-11-18 13:25:31 +00:00
488b55856e
Fix a problem causing an OOM within an ALTER TABLE ADD COLUMN command that adds a column with a CHECK constraint to go unreported.
...
FossilOrigin-Name: a33f5e93ecb7d84291f6fecc7b60f0c555034aa47e24584c63c78d8a94710d82
2021-11-16 13:36:50 +00:00
9dc718856f
Strengthen the sticky-CORRUPT idea of check-in [3feb0f1c3840904d] by
...
automatically changing the first COMMIT after an SQLITE_CORRUPT error into
a ROLLBACK.
FossilOrigin-Name: bd66ab8a1bc3c43a57c7caff5f54545b0feb0177f1f51492f30d308c123c43ba
2021-11-15 19:10:13 +00:00
3ce76a0bbb
Small performance optimization in sqlite3VdbeHalt().
...
FossilOrigin-Name: 9e1ecf438cb01d3d76950bcce1b3e4df29bedbb8176c8cede27e66f8e53e2098
2021-11-15 18:50:02 +00:00
8745f8a3c3
Fix a problem causing the count(*) optimization to be misapplied in some cases where an aggregate sub-query uses a count() expression that is aggregated against the outer query.
...
FossilOrigin-Name: e30917278c0ec750b1756ddc5e32d65c55464531d6ef64d2e72a412dfe634f58
2021-11-15 14:11:23 +00:00
5b001cc25d
Improved context shown for the "ABORT-due-to-error" output line when using
...
"PRAGMA vdbe_debug=on" in an SQLITE_DEBUG build.
FossilOrigin-Name: c7776369bcd0dbeb418b14d5dc681a81ee426234cc3f4f79a3c899d7892e1560
2021-11-15 13:22:42 +00:00
146121f5cb
Improved handling of OOM while reallocating a column name to add type
...
information. dbsqlfuzz 5a195b4233649e49e0aa34f1b743ca192d85b198
FossilOrigin-Name: 5995dd4de4997c43b43befc1281ef6378f33f781134c7f368299d64db2344f1d
2021-11-12 14:39:49 +00:00
9135ebb7db
Make sure the rowid value returned by the VUpdate opcode is always initialized.
...
FossilOrigin-Name: 150b5be5d5771485f521e3a58312596ecdcd35f3a0ae9d42d88bb99348a197c4
2021-11-11 23:52:44 +00:00
f9241a5fd0
Remove a NEVER() that was add yesterday. The fuzzer found a new test case
...
to make it happen.
FossilOrigin-Name: 83e6ac71073edfa0cd73788c30bdd5f09cb04c8a6a7d5123123dbcd354f430b8
2021-11-11 16:26:46 +00:00
3ab4ffce1f
New assert() statements to help prove correct usage of VdbeCursor objects.
...
FossilOrigin-Name: 7cee62f77a9e7c3cf886f136e75a93c3bbbb88e48b66035883bea5503d9fc03c
2021-11-11 11:23:08 +00:00
46c425b4dd
Make SQLITE_CORRUPT sticky: If a CORRUPT error is returned, all subsequent
...
write statements within the same transaction also fail early with
SQLITE_CORRUPT.
FossilOrigin-Name: 3feb0f1c3840904d28fc9a61262820e2b9b764addc1dd178aecc2cd0f952042c
2021-11-10 10:59:10 +00:00
90cf38be63
Refactor the code that figures out which SELECT in a cascade of nested queries
...
a particular aggregate function belongs to. This fixes the problem
reported by [forum:/forumpost/c7cc2aa3546e39c1|forum post c7cc2aa3546e39c1].
New test cases in dbsqlfuzz and th3.
FossilOrigin-Name: 74aec5dd1df95b5635f4da1f13753f113ea1d61de3dc3a1523ba51089c1900e4
2021-11-08 23:24:00 +00:00
a32536b498
Fix the zeroblob() function and related APIs so that they work with SQLITE_OMIT_INCRBLOB builds.
...
FossilOrigin-Name: bc401a75dd9f3c29c5969ae36264e68ccefc0937e44e232ca1f6b550f7fd6e22
2021-11-08 19:35:26 +00:00
1a39e45619
Fix an assert() in memdbTruncate() that could fail when processing a corrupt database.
...
FossilOrigin-Name: b1e2929860557cf88f98f0a4f2472e1a16be126bbb8050f0d728350f0cfe987a
2021-11-08 15:46:08 +00:00
6d64b4a027
Ensure that the window function rewrite does not leave the parse tree
...
in an invalid state that might cause problems downstream before the
error is recognized and unwinds the stack. Also take steps such that
an invalid parse tree does not cause problems even if it goes
unrecognized.
[forum:/forumpost/398e9d5aa9|Forum post 398e9d5aa9].
FossilOrigin-Name: 0f9fc6b6073365d5159cd71e7fe08f8dadbc7b42abd324361e809502f4359155
2021-11-07 23:33:01 +00:00
7b108e4cfd
Add ALWAYS() to a branch made unreachable by the previous check-in.
...
FossilOrigin-Name: 0dc963f63aebc42960125f96865029f16b3f6867126aab350da12882505edb82
2021-11-06 20:25:29 +00:00
35c7312ff0
Return an error if an attempt is made to drop an eponymous virtual table.
...
FossilOrigin-Name: 889dea52de874cd3bda9e811ef1e4ca53ab794ecabc65e9c780d9fb01eff3b2c
2021-11-06 18:22:50 +00:00
62561b82f2
Avoid accessing the sqlite3_module.xShadowName field if (sqlite3_module.iVersion<3).
...
FossilOrigin-Name: a024764cef955099b498ea120d4127144880db6da411f074cf0fd1276989204e
2021-11-06 10:59:27 +00:00
c18e022f15
Update an assert() statement to conform to the changes of the previous check-in.
...
FossilOrigin-Name: b5c668cac831425fd3e370142f9ea501bf2ca1c77c3eb0c5b8f0a574f7667b3c
2021-11-05 19:52:27 +00:00
drh