Commit Graph

8353 Commits

Author SHA1 Message Date
danielk1977 546820e321 Fix readDbPage() so that if an SQLITE_IOERR_SHORT_READ is encountered, the page content is zeroed. Ticket #3756. (CVS 6395)
FossilOrigin-Name: 647e3b156e32e37debd60b0079fc5a52bdc9b8c8
2009-03-28 06:59:41 +00:00
danielk1977 717811c995 When "PRAGMA case_sensitive_like" is invoked, override all existing "LIKE" functions, including UTF-16 versions. (CVS 6394)
FossilOrigin-Name: 1c6521e53b846eec2e046b1e9c04c60658b8e0e8
2009-03-27 15:26:03 +00:00
drh bcf4f4840b Fix another compiler warning in the test logic of tclsqlite.c. (CVS 6393)
FossilOrigin-Name: 47ffc4dca8f106d0da8cbc0a8ff7453016e9b40d
2009-03-27 12:44:35 +00:00
drh 69910da997 Fix some compiler warnings in test code. (CVS 6392)
FossilOrigin-Name: a43ecc9cb91ea8693e0fcce12c1bb5c5e4baf434
2009-03-27 12:32:54 +00:00
danielk1977 62e5a81a5a Fix an incompatibility between the test_async.c backend and change (6390). (CVS 6391)
FossilOrigin-Name: 6762625d29d5e0053afdad033fe54e2d9121046a
2009-03-27 09:10:12 +00:00
danielk1977 ee8b799d47 Check that the first byte of a potentially hot journal file is non-zero before beginning hot-journal rollback. Fix for #3751 and #3745. (CVS 6390)
FossilOrigin-Name: 80241a050296067937d0b0529fdf0c347358f86c
2009-03-26 17:13:06 +00:00
danielk1977 5a2cc667ca Ensure that the test vfs in test_journal.c zeroes sqlite3_file.pMethods if an xOpen() call fails. Similar problem to that fixed by #6384. This was a problem with test code, not SQLite itself. (CVS 6387)
FossilOrigin-Name: 45ae830d5631afa5d994361f5122c2f0b6fbab4c
2009-03-26 11:49:11 +00:00
drh 7c01f1d754 Remove an unused parameter from sqlite3DequoteExpr. Fix another unrelated
and harmless compiler warning. (CVS 6386)

FossilOrigin-Name: 8589b0fcc51a32188386e442655fd91f421ca7f8
2009-03-25 16:51:43 +00:00
danielk1977 357864ecb6 Fix a problem preventing sqlite3_extended_errcode() from working correctly. (CVS 6385)
FossilOrigin-Name: de469c46f55bf772ab8a49a185dc1b87360a937f
2009-03-25 15:43:08 +00:00
drh 072db2fb13 When a VFS.xOpen fails, make sure the pMethods pointer is zeroed on the
sqlite3_file object so that subsequent xClose() operations against that
same file handler are no-ops.  Bug in the test_async.c module only - not
in the core library.  Ticket #3744. (CVS 6384)

FossilOrigin-Name: c32b454118f4b0cc615edb9b35f749db45f6b36d
2009-03-25 14:24:41 +00:00
drh 892404323f Use fdatasync() only on linux, unless -Dfdatasync=fdatasync is set at
compilation time. (CVS 6383)

FossilOrigin-Name: cbf2ca4cc41f1f710635b863db6e98074bd5e8bc
2009-03-25 01:06:01 +00:00
drh 72bcfa6eeb Change OS_UNIX to SQLITE_OS_UNIX in test_thread.c. Modify notify2.test to
print out its timings in addition to reporting success or failure. (CVS 6382)

FossilOrigin-Name: 940d72d2bae95ddd1aea9b63424179735f440296
2009-03-24 18:42:16 +00:00
drh 9a6dedaef8 Include sqliteInt.h in test_async.c so that the asynchronous VFS tests
will run even if SQLITE_OS_UNIX is not explicitly defined. (CVS 6379)

FossilOrigin-Name: 29b0d6a3fe519c71a92e2436d7c5860f3f0178ef
2009-03-24 16:27:09 +00:00
drh 1af466eb6b New assert()s added to verify that the Expr.token value is used correctly. Ticket #3743. (CVS 6378)
FossilOrigin-Name: cf3d84ab73b7f519921a984f88bdad81996a3a82
2009-03-24 15:31:28 +00:00
drh d9da78a2c8 Changes to insure that lookaside memory allocations are never used to hold
schema content.
Ticket #3743. (CVS 6377)

FossilOrigin-Name: ea74d8dc62f5784089aa8ef098e97c505a79b176
2009-03-24 15:08:09 +00:00
danielk1977 4be6469146 Add a comment to prepare.c explaining why the lookaside buffer is disabled before sqlite3_exec() is called to parse a schema statement. No code changes. (CVS 6376)
FossilOrigin-Name: 8ca6a665650c9683a202f3ced17b14f7c85624bf
2009-03-24 04:46:08 +00:00
drh 347a7cb35b Clarify the meaning of a comment. No changes to code. (CVS 6375)
FossilOrigin-Name: 7c2df04b52a40d5d1b744ad1097f7c12143d8c2c
2009-03-23 21:37:04 +00:00
drh 7047e25c45 Add asserts to make sure that database connection locks are held when
accessing the lookaside memory allocation buffers.  No defects were found. (CVS 6374)

FossilOrigin-Name: 8a9f3e66069146ad1b1bc2686567882dc87603a9
2009-03-23 17:49:14 +00:00
danielk1977 a8bbef84bf Fix an obscure race condition that can occur when multiple threads, shared cache and DDL statements are combined. Enhance notify2.test to test this scenario. (CVS 6373)
FossilOrigin-Name: 92ec5975123284aff3a69ee16c397d9e2a844c0b
2009-03-23 17:11:26 +00:00
danielk1977 bc73971db6 Use the ROUND8() macro to round an integer up to the nearest multiple of 8 and ROUNDDOWN8() macro to round down to the nearest multiple of 8. This is a cosmetic change. (CVS 6372)
FossilOrigin-Name: db1d4d2f5083adf5438c7f387b115180800e7bd9
2009-03-23 04:33:32 +00:00
shane ca18d20fd6 Fix compiler warning in MSVC. (CVS 6371)
FossilOrigin-Name: 83a4d5b3d7abe983c2be00a694cc7d4c4847f253
2009-03-23 02:34:32 +00:00
drh 296a483c2e Allow the keyword INDEXED to be used as the name of a table or index or
column - for backwards compatibility. (CVS 6370)

FossilOrigin-Name: 53149c9f5d5cfaba3374703cd3af92a9d4cf8718
2009-03-22 20:36:18 +00:00
drh 0fa991b9e3 Update comments in build.c to conform to the latest implementation. (CVS 6369)
FossilOrigin-Name: a915e8e0a429ab6a10536c45264a790c2d076461
2009-03-21 16:19:26 +00:00
drh 4a7384a25f Rig the unix backend to use fdatasync() by default, without having to set the
HAVE_FDATASYNC macro.  Systems that do not support fdatasync() can be compiled
using -Dfdatasync=fsync. (CVS 6368)

FossilOrigin-Name: a331562727be465874a66c2c1d15ee070f96f7e0
2009-03-21 14:56:52 +00:00
drh 0b647ffd47 On unix, always use fdatasync() instead of fsync() when available, even if
the file size changes, since (we are told) fdatasync() will automatically
flush the inode when the file size changes. (CVS 6367)

FossilOrigin-Name: 0d6b11bcf67f86e5554806869d32338e5831833e
2009-03-21 14:41:04 +00:00
danielk1977 c926b6a65b Fix an assert failure introduced by (6355). (CVS 6365)
FossilOrigin-Name: a08324d16d1e9a4e7c1b294bc71fc939d173f826
2009-03-20 14:42:11 +00:00
danielk1977 be2296501c Make sure struct WhereClause is aligned on an 8-byte boundary. Fix for #3613, #3736. (CVS 6364)
FossilOrigin-Name: 093a0cf4adc8613f744c2ccdef61f0b30a46818c
2009-03-20 14:18:51 +00:00
drh 7555d8ec40 Rename the unused MEM2 static mutex to OPEN and reuse it to serialize access
to the sqlite3BtreeOpen() routine to prevent a race condition on detection
of sharable caches.  Ticket #3735. (CVS 6363)

FossilOrigin-Name: 19fa5a29b97f017a9e176e48c848100299ba6920
2009-03-20 13:15:30 +00:00
danielk1977 238746a650 Fix a couple of fairly obscure cases where an assert() could fail following a malloc failure. (CVS 6360)
FossilOrigin-Name: cc0d925669ddeb55048e88aa5b4f658be60b0962
2009-03-19 18:51:06 +00:00
danielk1977 65a2ea1155 Change sqlite3_step() to return SQLITE_LOCKED if a statement cannot be re-compiled due to locks on the shared-cache schema. Also add a blocking wrapper of sqlite3_prepare_v2() to the test code. (CVS 6359)
FossilOrigin-Name: e8be1af922098e298902820730f8b28603bd6fae
2009-03-19 07:58:31 +00:00
danielk1977 cb9d8d8821 Fix a crash that could occur when creating an index in shared-cache mode with lookaside enabled. (CVS 6358)
FossilOrigin-Name: 097737e3689b9a7e32815fe9c6fc6eed796ae53c
2009-03-18 18:43:36 +00:00
drh 0bb1221eed Add comments and testcase() macros to the fix for shared-cache schema default
value problem of check-in (6353). (CVS 6356)

FossilOrigin-Name: 05d8607d44cd3ff262c07cc1192f4471f3192b09
2009-03-18 10:36:12 +00:00
danielk1977 bd43455c38 Fix some cases where executing SQL from within a user-function callback could cause problems related to statement-transactions. (CVS 6355)
FossilOrigin-Name: a60f4191791dd7bb49d5c95b350a9924845b59a8
2009-03-18 10:33:00 +00:00
drh 7f75122149 Move the rowid cache out of VdbeCursor and into BtCursor. When multiple
BtCursors are open on the same table, set their rowid cache all at the
same time.  Ticket #3731. (CVS 6354)

FossilOrigin-Name: 189785832a7dc9f4a0a2113d850b92b987e0f9bf
2009-03-17 22:33:00 +00:00
danielk1977 21822c58b0 Fix a problem that could cause a crash when a shared-cache schema contains column default values. (CVS 6353)
FossilOrigin-Name: afadddc34eee3d6a39102b790ce1a869b33d4286
2009-03-17 17:48:59 +00:00
drh 8948747d8d Additional hyperlinks in the sqlite3_unlock_notify() documentation. (CVS 6349)
FossilOrigin-Name: 4dae5f6ed1662ca1c5c26d57049f7d349299468c
2009-03-16 13:37:02 +00:00
danielk1977 404ca07578 Add the sqlite3_unlock_notify() API. (CVS 6348)
FossilOrigin-Name: b649a6cc5bfefddd6a04b1183647d2923e0a0daa
2009-03-16 13:19:36 +00:00
drh 93a989cf65 Remove surplus white space from shell.c. Use strlen30() instead of strlen(). (CVS 6346)
FossilOrigin-Name: 324a1aff300b7349b9fc1dea56d640d86500f100
2009-03-16 10:59:44 +00:00
danielk1977 1b870de6b0 Fix for #3719. When synthesizing a CREATE TABLE statement as as result of a "CREATE TABLE AS", quote the column type names unless they are simple identifiers or simple identifiers followed by one or two dimensions (e.g. "VARCHAR(10)"). (CVS 6345)
FossilOrigin-Name: 7c6437efe0a0e935cfa8041bd6b94070c8654fa4
2009-03-14 08:37:23 +00:00
danielk1977 9365c6760a Do not overrun a buffer in the genfkey code (now part of shell.c). Fix for #3722. (CVS 6344)
FossilOrigin-Name: 943b11fb188835f0c62b6064b084192b1bbe1c0c
2009-03-13 15:32:53 +00:00
danielk1977 20736d82e2 Make calls to sqlite3BtreeRollbackStmt() no-ops when passed a Btree* handle that does not have an open statement transaction. Ticket #3718. (CVS 6342)
FossilOrigin-Name: a1bb1aef0e06140a2d5d5e4b6c10c73ce95c89e0
2009-03-12 14:43:27 +00:00
danielk1977 6fa0fe13f0 Begin purging dirty pages from the cache once 90% of the cache is dirty (insteadof waiting until it is 100% dirty). This improves performance in some circumstances by effectively reserving 10% of the configured page-cache for frequently reused read-only pages. (CVS 6341)
FossilOrigin-Name: 823fe7f5551e121e211d1ede606a7ce7487ffe0d
2009-03-05 14:59:39 +00:00
danielk1977 c427740b78 Comment out a recently added assert statement that is failing. (CVS 6340)
FossilOrigin-Name: d0b2015f1caf2fc60ec82bd8e760f7b61befa3b4
2009-03-05 14:53:18 +00:00
shane 50daafc74a Implemented winSectorSize(); Other changes for consistency. os_win.c. Ticket #2931. (CVS 6339)
FossilOrigin-Name: 68abcb278ced40c0d97af724dbd1b751a3becdc2
2009-03-05 05:54:55 +00:00
shane e34c647ed0 Added some asserts and a check for a null pointer dereference. (CVS 6337)
FossilOrigin-Name: 6b0cabd017ed25530b2d918d2c069fcbdd60a3f6
2009-03-05 04:23:47 +00:00
shane be21779385 Corrected typos and misspellings. Ticket #3702. (CVS 6336)
FossilOrigin-Name: 6404afa0c515a6536fc2e878d4fb451e4dc06942
2009-03-05 04:20:31 +00:00
shane c0688ea172 Removed compiler warnings from MSVC builds. Ticket #3701. (CVS 6335)
FossilOrigin-Name: 5477833ec7f707ea9937d3fd6a6d8ab49f2016f1
2009-03-05 03:48:06 +00:00
shane ce6fa1706a Converted EXPR_*SIZE macros to use offsetof() to avoid MSVC compiler warnings. (CVS 6334)
FossilOrigin-Name: 5e8e16f7d505a4b21272f1d300f366ee0e211e56
2009-03-02 17:18:48 +00:00
drh 18209cd6e2 Fix the SQLITE_ENABLE_UPDATE_DELETE_LIMIT option for the new Expr compression
logic of check-in (6305).  Bug discovered during regression testing. (CVS 6333)

FossilOrigin-Name: 91969edac737adf087e35e10aa0a732b3303afd5
2009-03-02 14:24:21 +00:00
drh d742bb78f8 Fix a bug in the GROUP BY alias name resolution. The bug was by
check-in (6305).  Discovered by regression test on 64-bit linux.
Test cases added so that the problems is detected on 32-bit systems. (CVS 6332)

FossilOrigin-Name: fa0008502ec4f891bfed4a11f01650d274f95c44
2009-03-02 01:22:40 +00:00