paulhorn/sqlite
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
31,453 Commits 1,696 Branches 387 Tags
976b50620a970f287c2c7efadd89f5e72f1f0e85
Commit Graph

313 Commits

Author SHA1 Message Date
drh 72afb50a6d Fix TEMP INSTEAD OF triggers so that they work on TEMP views. 
[forum:/forumpost/2026-02-28T23:33:04z|Forum post 2026-02-28T23:33:04z].

FossilOrigin-Name: 0596bd508f0bc548158858a1dc113af2235d02632ce8c41cd27d1029e1a7e48d
 2026-03-02 15:34:16 +00:00
drh 990d861038 Add new assert() statements to demonstrate that the complaint given in 
[forum:/forumpost/56ad8b632c|forum post 56ad8b632c] is not a real bug.

FossilOrigin-Name: d62999907d5f5987fe0030e1a4a7144c898e55595ac116eec966741a5099322b
 2026-02-13 16:02:27 +00:00
drh 174dabe096 Add experimental compile-time option SQLITE_ALLOW_TRIGGERS_ON_SYSTEM_TABLES. 
FossilOrigin-Name: f916bcc8657a4db2d069018751815f2ad91851499add761b1eb119f265b72a09
 2025-12-19 13:17:40 +00:00
dan 7b60ed803b Fix a memory leak that could follow an OOM on this branch. 
FossilOrigin-Name: 3223fee0b93bbbe277b955a98c13bb583ded78109f8e601c9ec0a7bd3749fd55
 2025-12-01 18:11:08 +00:00
dan 73937f0ca8 Fix another crash on this branch that could follow an OOM. 
FossilOrigin-Name: 75c49267ec6b84c8aad0e264c34506e4b24f69475ae5def0ee7530ba3822c15d
 2025-12-01 17:39:04 +00:00
dan ac0f2d5897 Fix a crash that could occur following a parse error on this branch. 
FossilOrigin-Name: 951b4533509fae971e252be3ecd3623ac2bdce16220e0ce372e600f728f80f69
 2025-12-01 17:22:15 +00:00
dan eeab52901c Fix another problem that could follow an OOM fault on this branch. 
FossilOrigin-Name: c4cc80eb281f7c8da3d62fec03b2258ce8d0063fc9cfff61f2cbcdd01e13c391
 2025-11-18 19:58:56 +00:00
dan b2029ca07d Avoid a segfault that could follow an OOM in an ALTER TABLE statement. 
FossilOrigin-Name: 0e4c2b889edbe801bb8ff29bbdb0b3139bdc85e696ccdf5bf51d7e5f9fdde961
 2025-11-18 19:48:39 +00:00
dan 11b6fc93f6 Experimental change to allow triggers in the temp schema to use fully qualified table names in INSERT/UPDATE/DELETE statements. 
FossilOrigin-Name: 48e168007ceb1bdc54cf21a8e959a8e0f9ccdc478827db7a7a0518fc7a226401
 2025-10-29 20:57:44 +00:00
drh 8725bf916d Fix harmless compiler warnings arising from [1cccea0508f5c8b8]. 
FossilOrigin-Name: d682557464a6069a93f890bb0aa983cea020ccde8261335ceeab19b9b6423863
 2025-08-04 11:50:41 +00:00
stephan d38777134b Move the flexarray union members from [527bbc1676a85a9] to the end of their respective objects. 
FossilOrigin-Name: 3082e07926695863bd5ef51c3c4803fbe267dc0d9b6ac9a717c225459f8988ba
 2025-07-30 21:34:47 +00:00
stephan df23b518da Apply alignment-related patches suggested in [forum:41cd226375cd49c6 | forum post 41cd226375]. 
FossilOrigin-Name: 527bbc1676a85a927352cd10a292afe041a72692ec0b1360e5a1ccaa19a32fcb
 2025-07-30 19:48:12 +00:00
drh cebf06c798 Make use of the flexible-array feature of C99, when available, to try to 
pacify -fsanitize=strict-bounds.  This check-in fixes the core. There is
more yet to do in FTS3, RTREE, and in FTS5.

FossilOrigin-Name: 6fd6b32d06bd6a705e5140cd613af823b8183a6f6a9ceeeedfcf5e8b50821d68
 2025-03-14 18:10:02 +00:00
drh 7fd936e5ed Further reduction in the amount of memset() needed to initialize the Parse 
object.

FossilOrigin-Name: 45e462c0060e51c3375a226d636148e3415ee6020e544ecc84861c7aef4ecf7b
 2025-02-07 15:49:21 +00:00
drh ede1690cce Reduce the amount of memset() needed to initialize the Parse object. 
FossilOrigin-Name: 284538d8486ef3e9bee1ab980043b53c144743c31b984be13a5cc137e7cbec31
 2025-02-07 13:37:15 +00:00
drh 35d302ccb1 Increase the maximum number of arguments on an SQL function to 1000 with the 
capability to increase it further up to 32767 using a compile-time option.

FossilOrigin-Name: e8d7d68ba0bb0bc2f948db5d9966990a5d23597fc3658b7cd0bc99d53c7353a9
 2024-12-12 15:11:27 +00:00
drh 692c160360 Tighter checking of access constraints on union members in SrcItem. 
Improved invariant checking.

FossilOrigin-Name: fd72d3400a8fe5747f494eee81654698acee350bb95b9db269e87d857af03492
 2024-08-20 19:09:59 +00:00
drh b204b6aa7b Give unique names to fields in the SrcItem object, to facilitate analysis of 
how those fields are used using "grep".

FossilOrigin-Name: 9f5aeef3cbc2c95267c8f7bf60d5c66971a76789669fb0e8f853273ff6f616f2
 2024-08-17 23:23:23 +00:00
drh 8797bd695f Reduce the size of the SrcItem object by combining fields into a union. 
FossilOrigin-Name: a4c59ac3c6ec979c25b544d29e47b8e39f6439c098eed8f84b3bd506c9adf047
 2024-08-17 19:46:49 +00:00
drh 0868d58e2c If a RETURNING clause contains a subquery that references the table that is 
being updated in the statement that includes the RETURNING clause, then mark
the subquery as correlated sot hat it is recomputed for each result and not
just computed once and reused.  See
[forum:/forumpost/2c83569ce8945d39|forum post 2c83569ce8945d39].

FossilOrigin-Name: 9ea6bcc8fdf6aadb756ec5bcaaa7af314167f8973bdd32fd23f83bd964f0c21e
 2024-04-24 16:36:37 +00:00
drh 35b771e221 Add comments linking the assert() added in [cef4d9e3ba586735] to the places 
where the precondition that the assert() tests are actually required.

FossilOrigin-Name: 6f0e7e195275aeb4aefd9da20348af35e3ef7f0a6b2768a34824daeace16eff1
 2024-04-24 11:51:51 +00:00
drh b065eceb56 Ensure that temporary SrcItem objects created by trigger processing have 
either SrcItem.zName or SrcItem.pSelect defined.  Every SrcItem should have
one or the other.

FossilOrigin-Name: cef4d9e3ba586735598f03eb5e8f29072c9e6f62b0d34ddd2fb3ed1795f6e21c
 2024-04-24 11:21:27 +00:00
drh 113e15fbbe Further enhancements to make sure the correct returnning trigger is run when 
there are nested INSERT RETURNING statements.

FossilOrigin-Name: d83405e870b071540b56e76291bdce1388db80b860afd68a34e4233f6ff2a3ab
 2023-10-26 16:59:22 +00:00
drh 3c75a03615 Deal with the case of a reentrant INSERT on a virtual table where the 
outer INSERT has a RETURNING clause but the inner does not.
dbsqlfuzz 3ac9a1e33f676254e02c0f297263b0a7aeb0c1a5.

FossilOrigin-Name: 8aba78e4dbf5c196aa50a28579f4bcd7c96103661c5968d62b2fded075bc73e4
 2023-10-26 12:59:41 +00:00
drh 6f12e51313 Do not allow triggers on shadow tables under defensive mode. 
FossilOrigin-Name: 44b932ff16e35814febd842d11215cf243393f173aade33ceded473598221e88
 2023-10-13 18:29:18 +00:00
drh 3cbf38c783 Fix multiple problems with RETURNING on a DML statement against a view, 
all inspired by [forum:/forumpost/dc3b92cfa0|forum post dc3b92cfa0].
(1) Do not allow a RETURNING clause to trick the code generator into thinking
that the view being updated has an INSTEAD OF trigger.
(2) Generate all result columns for a view in a DML statement.
(3) The automatic covering index for a view should cover all result columns
of the view.

FossilOrigin-Name: c8bedef0d61731c29ae34de1594222d15b578f9e2cddbbd5b74fb3059644fe0f
 2023-03-28 11:18:04 +00:00
drh a84ead119e Fix assert() statements that would (incorrectly) fire if an IF NOT EXISTS 
trigger that already exists contained two or more RETURNING clauses.
Tickets [89d259d45b855a0d] and [d15b3a4ea901ef0d].

FossilOrigin-Name: 648899e4ded72cac6cc24bccf7ebfc709ee7309a003452b21fd6ab0ba20c34b8
 2023-03-17 00:01:32 +00:00
drh 8c26e6fa16 Fix a possible NULL pointer dereference due to the sqlite3_interrupt() 
enhancement at [bd8fa10e59f58886].  Reported by
[forum:/forumpost/f5a2b1db87|forum post f5a2b1db87].

FossilOrigin-Name: 84417bbd144b2197c9930a520feb94b59053957c190be79f8deaaaebca68ecf1
 2023-03-08 23:05:18 +00:00
dan abbfa7aa17 Ensure the RETURNING clause is honoured when a row of a temp table is updated by an ON CONFLICT clause. 
FossilOrigin-Name: a2449bcc2c71d0f4c3289621fbf1cb97f0f407c9f7b5bf18245b7854a07c6cfa
 2022-11-28 13:47:27 +00:00
drh 7424aeff41 Replace the Parse.disableVtab field with Parse.prepFlags for increased 
generality, a small size reduction, and a small performance increase.

FossilOrigin-Name: b7da0bcdf70e53ab1ec00a0694e17c7429e23bc6eb3f39b622d06a930aa2f6a3
 2022-10-01 13:17:53 +00:00
drh 80cf891792 Enhance defensive mode so that it disallows CREATE TRIGGER statements if the 
statements within the trigger attempt to write on a shadow table.

FossilOrigin-Name: 3283bbd12a60f472ed03cb7c6209a605a3bf9f3d9083371e17840b56e8b3f559
 2022-09-27 00:56:45 +00:00
dan 4209d553e7 Fix further issues with ALTER TABLE and triggers that contain UPDATE..FROM statements. 
FossilOrigin-Name: 53fbc269ddbabc4a97d297e881e5f9cd2bfbcd24af4af1b7cf9db412a3a51813
 2022-05-27 15:04:43 +00:00
drh 26c4df0fb0 Correct handling of outer joins in the FROM clause of an UPDATE statement 
that occurs inside of a trigger.  Follow-on to [98b3816bbaf539ea].

FossilOrigin-Name: 664a49fa813144b6fa5a7ae3f65af5412f150dd5def261c4d581d706b39f7846
 2022-05-26 17:33:42 +00:00
drh d88fd53989 Organize the various flag bits of the ExprList_item object into a substructure 
so that the whole lot can be copied all at once.  Faster and smaller code.

FossilOrigin-Name: 5341d4bbe9a943f9cdbbdea829e18f108e98972ebb706396c50fc62fcc6a6328
 2022-05-02 20:49:30 +00:00
drh ce5dd9e8d6 Fix two unreachable branches introduced by the recent 
sqlite3TriggersExist() optimization.

FossilOrigin-Name: 1b5475d212cf9de0bff69eee8c607b4fcd8e04bf4df72171429e7609c4153951
 2022-04-07 20:45:38 +00:00
drh a744167956 Optimization to sqlite3TriggersExist() saves over 700K CPU cycles. 
FossilOrigin-Name: 5043a3507e0781878e0e1bea5095a33273958820baead4af8fc2929e9d7c07ee
 2022-04-07 14:03:07 +00:00
drh 389e056bfe Change a conditional into an assert() due to the change in 
[387ab17b8a0a4b87].

FossilOrigin-Name: 13b584869f40ea6aa2190dbac64709695ee8d72b27bc5afb8b39ab3763b9c46a
 2022-03-17 23:49:58 +00:00
drh 4c460bbffd Do not allocate new Trigger objects in the parser following a syntax error, 
to avoid violating invariants associated with Expr nodes.  See
[forum:/forumpost/2024e94071ef1531|forum thread 2024e94071ef1531] for more
information.

FossilOrigin-Name: 5e0ed49b3d739d292f5df3e498449ae8f4357cbb83394181fb34f98ed8372707
 2022-03-07 16:22:31 +00:00
drh e1c4743121 Disable the sqlite3_error_offset() when the error occurs in a trigger or 
view or some other bit of text that is not part of the original statement.

FossilOrigin-Name: 0e909e34fa74e7b9b7954e4ed4c39dd293c1d413b58fda03607faab74aa382ad
 2022-02-07 18:52:56 +00:00
drh 1da88b5ce6 Add ALWAYS() macros. Change some existing ALWAYS() into assert(). Other 
code simplifications.

FossilOrigin-Name: 4aa27b4fcd1ffd06c38357a87ba3f5776367570439c49652f0903873def0bb23
 2022-01-24 19:38:56 +00:00
drh 0c7d3d399d Remove many redundant checks for sqlite3.mallocFailed now that any OOM should 
cause Parse.nErr to be non-zero.

FossilOrigin-Name: 1f7fa46126ea33ed30e93186aff3df51068aeb4be6f79a102bfe8c4e44941d71
 2022-01-24 16:47:12 +00:00
drh c692df2784 Make it so that any Parse object is always linked into the database conenction 
while it is active.  Hence, an OOM will cause Parse.nErr to be set.

FossilOrigin-Name: 6a45d8fe8bfbc11a5b86d25237e1f8bccfb0f22f3dcaf004ba797aeb57b365ec
 2022-01-24 15:34:55 +00:00
dan f5bc444077 Ensure that any error encountered while coding a trigger program is transfered to the main Parse structure before it is used with any other routine that might set the error code. 
FossilOrigin-Name: 4293656578811b500786335de7cc9ac0d6ccc6fb273b9419a86968a095404c43
 2022-01-24 11:25:42 +00:00
dan c6977c1c0d Fix an assert() failure that could follow an OOM when coding a RETURNING trigger. dbsqlfuzz case 5d3e2438f15dc32b473d9f29413157857efa1212. 
FossilOrigin-Name: 7ae596dd4a73a09585c5dc9f4faf75d126d0733fc2fb32c1de64126a1088d967
 2022-01-05 15:54:02 +00:00
drh ebc4434e99 Improved handling of OOM errors in sqlite3ExpandReturning(). 
dbsqlfuzz 1040b720f0bbc3bdcfe7336acffbf71517e3ef82.

FossilOrigin-Name: 33c6b8e94bda12df13b4d2dd782b3120c3628596b86ef531d20b3100bf159b50
 2022-01-05 11:49:58 +00:00
drh 41584df573 Ensure that the affinity of columns is honored in the RETURNING clause. 
See [forum:/forumpost/e0c7574ab2|forum post e0c7574ab2] for the bug report.

FossilOrigin-Name: 4711fb69547f4f17653ab116030c32fdcc2c836410349d1d025866ffc15704da
 2021-12-29 04:31:54 +00:00
drh a4a871c286 Show the preferred schema table names in the output of "PRAGMA table_list". 
FossilOrigin-Name: 9147390d9885a37a62edc1058f313434627f1b59965c890877d2cb119e355c78
 2021-11-04 14:04:20 +00:00
drh cf9d36d1b3 Refactor field names in the Column object, zCnName and zCnColl, to make them 
unique and thus easier to find amid all the other code.

FossilOrigin-Name: 8b781dcaf68e0cf12a844708c82eee00193e340195cbca915d077e4846983bf3
 2021-08-02 18:03:43 +00:00
drh f38524d20d Refactor the Table object to reduce its memory footprint. 
FossilOrigin-Name: bbb6759bcf6e01d36dfc787a82a610d359f50aaeac8104b73883a84906d54e1f
 2021-08-02 16:41:57 +00:00
dan cf1e25566b When generating data for a RETURNING clause, avoid assuming cursor number 0 is available for use. 
FossilOrigin-Name: 4b2c59acce6ff1bb6c9c04c45c80945ae23a26588718cc20635d60f7497adabb
 2021-06-28 15:25:17 +00:00