drh
af03eb3241
Enable the count-of-view optimization by default.
...
Enhancement request [eaed8e36ce888f1e].
FossilOrigin-Name: a4aacdd323a854d771c8cb1e2e4cfc4fb66b0020cfed23525733603605f5c63b
2023-02-22 21:47:02 +00:00
drh
95dee6d2e3
Avoid computing the values for unused result-set columns in subqueries.
...
Performance optimization request [baa5bb76c35a124c].
FossilOrigin-Name: 7c2d3406000dc8ac5a99cc205b036356b67e4b0b94738592ffc5680749696904
2023-02-22 21:11:34 +00:00
drh
bcb3215630
Remove the push-down optimization restriction that was added by
...
check-in [1ad41840c5e0fa70] because it is no longer needed after
the enhancements to compound query processing in check-in [27655c9353620aa5]
This resolves the performance regression reported by
[forum:/forumpost/bcc4375032|forum post bcc4375032].
FossilOrigin-Name: aa6bd6dff751223e302575c60f335707e4bb820bff716cab3706b564e18ed7ed
2023-02-22 20:42:15 +00:00
drh
61f0a03492
Yet another comment typo fix. No changes to working code.
...
FossilOrigin-Name: cdbdc8013fcfa8ce1bd4f5521c8d98afc53b9c577d43e5e6d0d1e15c789b910f
2023-02-21 12:42:25 +00:00
drh
0c30eaec99
Fix a minor typo in a comment. No changes to working code.
...
FossilOrigin-Name: 7981671d1449b3fc6eb214deb558d91b87dc4fa6e38e24606625a146cc71664a
2023-02-21 12:34:00 +00:00
drh
6e2b2f3073
Fix formatting and improved documentation on the various sqlite3_file_control()
...
opcodes. Other minor documentation changes. No changes to working code.
FossilOrigin-Name: 13280f720a4ef5a1f7f2a2fbe72f374d3a2e12be9bc0c50f7fce50d0cd28a67f
2023-02-21 12:30:18 +00:00
drh
ffe9bfd8e9
Fix an incorrect #ifdef in the CLI.
...
FossilOrigin-Name: 3c4d29cf227511bf218ef620d497dc72c708dcc819971b34c7629f3ed11803fb
2023-02-20 16:55:58 +00:00
drh
e17cac189f
Fix a harmless compiler warning.
...
FossilOrigin-Name: b2534d8de5051a3516f4b9ee5a4b99e1dcf455e9af88c60815d2c2a479fc8566
2023-02-19 19:16:51 +00:00
drh
1603f7edee
Fix stale requirement marks and fix a typo in the documentation for
...
sqlite3_preupdate_hook().
FossilOrigin-Name: 655991f5d9afdd3281049eb430921046e0ba90eef215020c2fb149adc0d3c4c5
2023-02-18 20:31:26 +00:00
drh
3c7e90b894
Fix a harmless UBSAN warning in debugging code of the new unhex() function.
...
FossilOrigin-Name: 315574d5cbe5c805ff2163052d986b054985984fb45bfb064d1a7b39a22b90eb
2023-02-18 15:50:23 +00:00
drh
ab31a5df93
Do not allow the COUNTOFVIEW optimization to run if the count() contains
...
a FILTER clause. dbsqlfuzz 4f8e0de6e272bbbb3e1b41cb5aea31e0b47297e3
FossilOrigin-Name: 29fc06465efb948f98d2733bb25ffa1e0662a0189304006b3d0be9fec7dd28c5
2023-02-17 18:27:48 +00:00
drh
7defd20cb0
Provide an optimization-disable mask for this optimization. Do not do the
...
optimization if the subquery is an aggregate or is distinct, but allow it to
be an ephemeral subquery. Do not omit columns that are used in the ORDER BY
of the subquery.
FossilOrigin-Name: 6b1a1f374d1372f11f5420d99645b218867100bf070bd3a8885bf5f00c189dff
2023-02-16 18:04:49 +00:00
drh
90b7af7715
Do not perform the omit-unused-subquery-columns optimizations on a
...
subquery that is DISTINCT, as that can lead to incorrect results.
FossilOrigin-Name: cc148503db8ef180bce984328da7e84959afadd6a9613c2d03bc1eafeb95dfad
2023-02-16 15:54:55 +00:00
drh
6945ba787f
Fix the subquery result column NULL-ifier so that it correctly handles
...
subquery columns past the 63rd column.
FossilOrigin-Name: 77b220a7240425fa83e142ceef78505208e6e38d797070e146b9f7d255f753c7
2023-02-15 19:53:08 +00:00
drh
e3ec00ccb8
Do not compute result columns of subqueries that are never used. Make those
...
columns NULL instead. This optimization potentially resolves the enhancement
request described by [/tktview/baa5bb76c35a124c|ticket baa5bb76c35a124c].
FossilOrigin-Name: 5dec3cc0225296a043d17f73126d477d90a604f82b3180628176d8f950adbce8
2023-02-15 17:53:17 +00:00
drh
d6ba4252b2
Ignore extra parentheses around a subquery on the RHS of an IN operator,
...
because that is what PostgreSQL does.
FossilOrigin-Name: ecdeef43b27412b0b0b09e09a62ad3a03836a3fc80f2070268090e7ca8f02712
2023-02-13 19:32:40 +00:00
drh
b4dc263ec5
Do not allow WHERE clause terms to match constant string index terms, which
...
can happen if DQS_DDL is enabled. Follow-up to
[44200596aa943963]. dbsqlfuzz 54c9db85ed4af7055f5fd0d50877875c82b11d46.
FossilOrigin-Name: 2d2b91cc0f6fed8cb6f738dc7019047ce0f1e86b5eb8efa997095d08a32cbcb6
2023-02-13 18:42:01 +00:00
dan
1aacb3b02f
Allow vector-IN expressions like "(a, b) IN ( (?,?), (?,?) )" to use an index.
...
FossilOrigin-Name: 18a99d9cfbc3a0419342b3fe91a83d2217578d0f6e8ee1084237d000946b1942
2023-02-13 18:37:48 +00:00
dan
5c84aafd77
Fix compile time option SQLITE_DEFAULT_SYNCHRONOUS so that it works consistently.
...
FossilOrigin-Name: bf6f1ee77c4bf653f6cd2a3db5292b8c5c83f18ea9acf951107d22807546b28a
2023-02-13 18:26:58 +00:00
dan
0c69938511
Allow vector-IN expressions like "(a, b) IN ( (?,?), (?,?) )" to use an index.
...
FossilOrigin-Name: 1815b15ddb8785a25b7617aab19e13c2410b9377389c16a85176025b3d9400e8
2023-02-13 16:10:31 +00:00
drh
9e463e878d
In the LIKE optimization, do not analyze the new virtual WHERE clause terms
...
until both have been added, since they are expected to be consecutive and
the analysis might add complementary terms.
This fixes a problem caused by [44200596aa943963] and discovered by dbsqlfuzz
and recorded as case 7e3b5983727d843b910b2d9ab556e4afcd777cfb.
FossilOrigin-Name: d35de3ad3fac6b30d3f266cbe4b1e9923eb31a1eff4a869205bbc3ba122eeec5
2023-02-13 12:46:22 +00:00
drh
0c55b5fd1c
Change a variable from 32 to 64-bits to avoid a harmless compiler warning
...
in Xcode. [forum:/forumpost/402d733c22|Forum post 402d733c22].
FossilOrigin-Name: 0216ce23cf23bc147c5de6de178a6689b7ad744bf0ee0098809938b5fe10708b
2023-02-11 21:11:39 +00:00
drh
80e936aef0
Do a better job of detecting when a WHERE clause term might be useful to
...
an expression index. Fix for performance regression reported by
[forum:/forumpost/e65800d8cb|forum thread e65800d8cb].
FossilOrigin-Name: 44200596aa943963bc6ca98b5d4fd5b9235d1109d8dfc1a75eeae353b4239142
2023-02-10 21:53:33 +00:00
drh
74e6e30358
Ensure that the valueFromFunction() routine does not clear a prior
...
parser error. dbsqlfuzz 6fa816f20cf5b62260d635d110b88f38e29d8fe1.
FossilOrigin-Name: 734766451123c98a467c3407562eaa097b3307c8a275e1c8dd93e4654fe78014
2023-02-10 14:20:18 +00:00
stephan
5b56a13977
Squelch two harmless signedness comparison warnings in shell.c.in.
...
FossilOrigin-Name: bdd3edec13fa1142a8074c316e9ecec93fb278d42836eeb38587376fdf22cebd
2023-02-09 12:59:44 +00:00
drh
a0c8ec9ee5
The "flexnum" affinity that was added by [44135d6ea84f7ba6] needs to also
...
be added to the output of the affinity() built-in function.
dbsqlfuzz d309eaa5fe492c9606a8be876c2bc7dedb29d3d8
FossilOrigin-Name: f4ec68ceefa3a607f37d6355aac89fd1ae1704da4061bad7f271db1f17c1dd3a
2023-02-09 11:51:40 +00:00
drh
601e4d4a0f
Back out the 'txn' enhancement to date/time functions. The duration of a
...
"transaction" is confused and needs to be straightened out prior to moving
forward with this change.
FossilOrigin-Name: 4a145f07322d768a07619bed27e0390d50f3a01d07787b9296234a5ceb6f1218
2023-02-08 20:29:48 +00:00
drh
03b30b7abe
Always use 64-bit integers for stats associated with STAT1 and STAT4.
...
FossilOrigin-Name: 6647d1cb8b53102c8114b1f3e34173d907504d78aa3140eab53f88027a36660b
2023-02-08 17:28:42 +00:00
larrybr
72ce57e675
Cause gcc warning suppression in shell.c to be nice in other project(s).
...
FossilOrigin-Name: 6b41ba2e996ab7b9c3943ab93a19748db5cf37792f5d59d20eec301085282355
2023-02-08 14:49:52 +00:00
dan
8ae1d29b13
Update an assert() in the stat4 code that is only true for a well-formed database.
...
FossilOrigin-Name: 04439f3b23b22a3c187637f286764568ee922227e3e34b2e63075876b4d1f2ac
2023-02-08 14:25:00 +00:00
drh
0873d88423
Fix an incorrect assert() in STAT4 logic added just a few days ago on
...
[2023-02-01|/info/55a26c67ed4a3a93].
FossilOrigin-Name: 168fa2fb22b8c1ad80c7001a429d3a80b48acfbfebb5414a0caa76964ea647c3
2023-02-08 14:17:34 +00:00
drh
821fe31fd7
Add the 'txn' date/time format. Change CURRENT_TIMESTAMP and similar to use
...
'tnx'-style semantics instead of 'now'-style.
FossilOrigin-Name: 61cc8ed8d3541eddf23a9d542179c3f0223c5b8519b54d3be79988a376e25a89
2023-02-08 12:47:37 +00:00
drh
ed092fc368
Revert the behavior of date/time functions with no arguments so that they
...
once again work like 'now', even while CURRENT_TIMESTAMP and similar work
like 'txn'.
FossilOrigin-Name: 06180caff0f5d8aba83b9f7be682ccdd6cb2ffc228b557ee6c1fd00fe5c23e92
2023-02-08 12:01:48 +00:00
drh
c1dab9ded2
Change the behavior of date-time functions without any arguments (and thus
...
the CURRENT_TIME, CURRENT_DATE, and CURRENT_TIMESTAMP variables) so that they
work like 'txn' instead of like 'now'. This is an incompatibility with legacy,
but brings SQLite into conformance with all other SQL systems.
FossilOrigin-Name: 1ac78be54502779236645eac35b962797f2fb98307d059d2aa19658c4fa74cb7
2023-02-08 11:34:05 +00:00
stephan
51b0373998
Merge wasi-patches branch into trunk.
...
FossilOrigin-Name: 9902e66a37d59c1909593bbc296091df3fa3bfa12ec7062bd84e458030f77c8d
2023-02-08 08:49:52 +00:00
drh
3393ee7ff6
Simplify the code and add test cases.
...
FossilOrigin-Name: d3bed4caff561e71c396cc869c5b4d9bf216ba203485e738c12ec62741f1aba5
2023-02-07 23:55:59 +00:00
drh
d4af882a1b
Add support for the 'txn' argument to date/time functions that works like
...
'now' but keeps the same time for the entire transaction.
FossilOrigin-Name: 5e4f45af96247e29910403a63ac148cb313b005f9c014b37a9a49d98f5fef9a6
2023-02-07 21:55:14 +00:00
drh
9d6725c651
Fix a typo in example documentation code for sqlite3_vtab_in_next().
...
FossilOrigin-Name: a95dbfae6133cc7aac950c3e7ba55a29d80b1625c39479a7d1d10b0868ee2be4
2023-02-07 16:58:58 +00:00
stephan
f8c73aed67
Merge trunk into wasi-patches branch.
...
FossilOrigin-Name: 656d36f50f630da68262469087bad1ac71b10325e233a7963103c8cbc232f61a
2023-02-06 22:25:18 +00:00
drh
913ea77443
Fix the build after the previous change
...
FossilOrigin-Name: aea3b6f6515bc3b7e7205b7d17d99cb1fc68030eb929d8adbe25f065668c9c95
2023-02-06 15:49:54 +00:00
drh
da3d655fd8
Remove the long obsolete "client/server" mode tests.
...
FossilOrigin-Name: 08e3114caec0633fc54f8febb7f4732b46a1f47508bbca0a6a2bff02591254d5
2023-02-06 15:46:34 +00:00
drh
072f48e556
Do not use a Bloom filter if any outer loop lacks STAT1 data, since without
...
STAT1 data, the query planner cannot make an accurate determination of
whether or not a Bloom filter will be useful. This fixes the problem
reported by [forum:/forumpost/56de336385|forum post 56de336385].
FossilOrigin-Name: e6ab96bd0b9efc51fd703bf7e92b079943ad9a3b92183d434adc11fb7d238afb
2023-02-05 20:29:10 +00:00
drh
8d07c3d497
Restore a test for pBt NULL that was removed by [12a14711afa6cddb] but turned
...
out to be necessary, as dbsqlfuzz quickly showed us. Test case added to TH3.
FossilOrigin-Name: 647c89dd2f90da1605e6fc01ecc8c1367c12c06b3a972ed682a69e85bf1d77e9
2023-02-05 00:47:27 +00:00
drh
2f9525b0ff
Changes to the sqlite_dbpage virtual table to tag or remove unreachable
...
branches.
FossilOrigin-Name: 12a14711afa6cddbf64d5307fd239fc597027d4356a431ad75836025f4bad83c
2023-02-05 00:24:42 +00:00
drh
111057cf66
Add ALWAYS() and NEVER() macros to unreachable branchs in sqlite_dbpage.
...
FossilOrigin-Name: db875cd6be3b6e0032325cf42e6846eb41a7f099eb4561baf402d914446b052d
2023-02-04 20:53:31 +00:00
drh
5db5c122ef
Remove an ALWAYS() that can be false in some very rare cases.
...
dbsqlfuzz 2274a23c85a93b870f7eb12fe686073da01abc33
FossilOrigin-Name: a4eb0b0d837291590958a5f292f41e80e0f722668a060aebfed5ea36ea176332
2023-02-04 20:07:52 +00:00
dan
fb962837fd
Updates to the testrunner.tcl script so that uses a separate sub-process for each test. And so that it runs the release test procedure currently handled by wapptest.tcl.
...
FossilOrigin-Name: 4c3c587500ac5a3758008f0acb9432bd3bc6f0f31bacd5615f46280e55842982
2023-02-04 19:01:17 +00:00
drh
ad1079e35c
Better error message when trying to do an INSERT on an sqlite_dbpage virtual
...
table.
FossilOrigin-Name: a98e4908dabc8f45f7859a26bd1d0c04de34ec68c1367c2cdd9b0242e08b938f
2023-02-04 14:23:26 +00:00
drh
989d0cec5d
Attempt to fix harmless compiler warnings that reportedly appear in clang 15.
...
FossilOrigin-Name: c045d76b908a8c90d22511df7884e78d452b250db9ba70d4cb0935048a3c3ac4
2023-02-03 14:57:40 +00:00
dan
60228cb3d2
Avoid using Tcl command [clock] in testrunner.tcl.
...
FossilOrigin-Name: b2faf9289f6fbbcd4491e1b063da731b35aeed9ff1fc97f64798e99cac847b4a
2023-02-03 11:32:51 +00:00