c7e93f58d5
Performance optimization in the code generator for INSERT for the common
...
case where the target table has neither generated nor hidden columns.
Also fix a redundant (and thus unreachable) branch in the resolver.
FossilOrigin-Name: 16ac213c57196361a9d14df4c0d1ccc6f67ac522365b345ea364d1aec61fa3f2
2021-02-18 00:26:11 +00:00
c54246ffdf
Use the sqlite3ParserAddCleanup() mechanism to ensure that the AggInfo
...
structure associated with an aggregate query is deallocated, for a performance
increase and size reduction.
FossilOrigin-Name: 7a1399671fa10c64d5358cc4d364d24c643fe9dd8da923356462267ee7962f61
2021-02-17 21:13:14 +00:00
4b0229ae1f
Enhance the ".once" and ".output" commands in the CLI so that if the
...
filename argument begins with "|" the name becomes the concatenation
of all subsequent arguments. Hence, commands like ".once | open -f" become
possible without the need for quotes.
FossilOrigin-Name: c46a94a624c2cc6c49ac916a206a913081e1628c24805987cabc75c9057ea36b
2021-02-17 13:19:22 +00:00
6b37b762ed
Simplification to the resolveAlias() routine.
...
FossilOrigin-Name: 00bead3931135af80475c22f08cbb26c914518e8f2c7e73c2b8be1cee4ac4d5e
2021-02-16 20:32:17 +00:00
13162ef975
New SELECTTRACE macros more clearly deliniate when the query planner is
...
invoked in the middle of PRAGMA vdbe_addoptrace output.
FossilOrigin-Name: 7c03ce49b74f72b63dd75c3a02625e671bfd771f71b24e808994322b00d97677
2021-02-16 20:01:08 +00:00
33941691a5
Fix an issue with the LIKE operator when it includes the "ESCAPE '_'" clause.
...
Ticket [c0aeea67d58ae0fd].
FossilOrigin-Name: 27d4117980d125975b5e70eeea58a6ab07bcf066e71b5fcb81b822e05afdbab0
2021-02-15 17:02:01 +00:00
351ae772a3
Ensure that the ALTER TABLE statements return 0 for
...
sqlite3_column_count().
FossilOrigin-Name: 29c1932a47cd46c2585ebbf937c03544a8a355014776129662789e15db9ed4de
2021-02-15 13:17:19 +00:00
8794c68a35
Avoid manifesting a CTE (or other view) multiple times when it is possible to
...
reuse the first manifestation.
FossilOrigin-Name: 9692f510803c9b9725abb687d7c10fbc0d5ed784479ec6f3fcc55925a87fe16d
2021-02-13 16:39:24 +00:00
e8f1490f55
Fix a problem in the unreleased union-all flattening code.
...
FossilOrigin-Name: e4f8a79fd8b3be9bf8add5f5e1c66bc2fe78da4e50ea500ab0b8370d30e31ba5
2021-02-13 14:26:25 +00:00
82ab4f6b1a
Correctly detect correlated subqueries when resolving names in RETURNING
...
clauses.
FossilOrigin-Name: b43cfa04922a401442b9d1708e3e4a88d3cfa2c591f9a6b253d99ba83f4b280a
2021-02-08 15:56:01 +00:00
d510197276
Improved name resolution for references to a table begin modified from
...
within a subquery in the RETURNING clause.
FossilOrigin-Name: 799d205bfa7945ee4a92dfec5fbf90a00b9a535e3171aab2ec46404f7efb0f78
2021-02-08 13:41:17 +00:00
e1c9a4ebf9
Do not allow RETURNING in the DML statements of a trigger.
...
FossilOrigin-Name: 7a8fe6463a9728bc4e34465688a059afb74f3c373cde8fdf570d5d148fdde04d
2021-02-07 23:28:20 +00:00
8729642112
Fix harmless compiler warnings.
...
FossilOrigin-Name: 5f8bf99579e6663fc701cdc94f685584a86398c4687e25e7e241de755398f17d
2021-02-07 12:59:43 +00:00
5f323787bd
Remove an ALWAYS() and NEVER() in the authorizer that become reachable
...
as of [078dbff04a95a001]. Test case for coverage in TH3.
FossilOrigin-Name: b469327e2949352325d3db815bd4782f9734239c378f08afd2f00ffa54bef924
2021-02-06 14:56:30 +00:00
8873aea390
Fix the OSSFuzz-discovered shift problem from two days ago. This patch was
...
omitted from [078dbff04a95a001] apparently because I made the edit to
"sqlite3.c" rather than "resolve.c" where it belongs.
FossilOrigin-Name: 864772ffec4e91d8d73f9b97e6e1d7bd4e0537de19d11d30aed7eedd5b7d394a
2021-02-06 14:37:36 +00:00
29f6a365cc
Remove unreachable code. Fix a shift UB problem introduced yesterday
...
and discovered by OSSFuzz.
FossilOrigin-Name: 078dbff04a95a001bbd8690ab08038fbb5506899df8290991b53fd1122a4c30c
2021-02-05 17:34:47 +00:00
7dec804d42
Remove dead code. Fix RETURNING for INSERT into a virtual table.
...
FossilOrigin-Name: dbfa38699c87ab4bf390666e411dda8d375c7b53b9b4fb131adacbf575867a72
2021-02-04 22:59:19 +00:00
e1db9343d5
Fix an issue with RETURNING from UPSERT.
...
FossilOrigin-Name: 757b74ba0fd64634a365bd73955181191767ad8816a33a362e32ece250299a51
2021-02-04 21:17:12 +00:00
552562c48f
Snapshot. New design appears to work on a simple test case.
...
FossilOrigin-Name: 8a65fbeecf3597e30853c5f0ccd9b8b46c508854fa521e58e0db279deebca7d4
2021-02-04 20:52:20 +00:00
381bdacc8f
Preliminary changes for a new implementation of RETURNING that captures all
...
results in a buffer and plays them all back after the DML statement
completes. This avoids problems with interleaved DML statements.
This particular check-in is a non-functional work in progress.
FossilOrigin-Name: 04b77d63216ce11b4e797946953bcde504fc005807c7a5ac757fbf47d78698dc
2021-02-04 17:29:04 +00:00
8ab79d6135
Add NEVER() to a branch that check-in [5d54d9fd40638138] apparently made
...
unreachable.
FossilOrigin-Name: 5c8e6296aa9f69a092364524b716ba894f113f7f1e6024b9a2eaa01c239e65c1
2021-02-04 13:52:34 +00:00
02c4aa39e7
Performance optimization in sqlite3FinishCoding().
...
FossilOrigin-Name: 0f34f241d37cc4f31dc657a6fc33815fa5e24298487121cb27c29118524b8ee7
2021-02-04 13:44:42 +00:00
17b74817c0
Change the name of Vdbe.magic to Vdbe.iVdbeMagic to disambiguate with
...
sqlite3.magic.
FossilOrigin-Name: 6b29e549bb34933bfd0758e31085e65dcc0f75446c478fc775d96cf01c22cf43
2021-02-03 18:32:25 +00:00
7937f63220
Avoid doing any foreign-key constraint related processing for an UPDATE statement that does not modify any columns that are part of FK constraints, even if the table has a self-referencing FK.
...
FossilOrigin-Name: 7f3b036e730153ac22933b03a52d4ec3978c9ecab1399d8cc79fe533893321e3
2021-02-03 14:20:56 +00:00
c5eb176a09
Fix a harmless compiler warning.
...
FossilOrigin-Name: 1eb69c64ed4a11601698000573c507684bc4b0366336ba0748ebd661644d0902
2021-02-03 13:20:12 +00:00
cd39cda00c
Add support for the RETURNING clause following PostgreSQL syntax.
...
FossilOrigin-Name: 416c898bfb8ff9639ffbaefcfb47fce3782763af1fc67969fa91c5f01a336676
2021-02-03 13:08:09 +00:00
78197e0f8b
Fix an assert() that might be off-by-one in the case of a prior
...
errors in the parse.
FossilOrigin-Name: 06b15b17be38c804dd2641d8616a2a7bd396d2eb9901a0fbf94edd8bd508cf9c
2021-02-03 12:35:51 +00:00
2aa41c82da
Modify the SQLITE_DBCONFIG_ENABLE_TRIGGER setting so that it only disables
...
main-schema triggers and allows TEMP trigger to continue operating. This is
safe, since only the application (not an attacker) can add TEMP triggers.
It will also all us to disengage SQLITE_DBCONFIG_ENABLE_TRIGGER on Fossil
databases since Fossil has no main-schema triggers but does use TEMP triggers.
FossilOrigin-Name: a10c5a2503ff2998f6ee40f721aab8c9579052e535dc141bd57d10551eaea387
2021-02-03 00:55:34 +00:00
47600083f1
Load enhancements from trunk into the returning branch.
...
FossilOrigin-Name: b84c7f60c2e1e7debf9f50622087f87d60c6870061d61e14e59cc1ba0775ee92
2021-02-03 00:05:57 +00:00
cb83dc9e95
Do not allow aggregates in a RETURNING clause. Fix a memory leak that
...
occurs when window functions are used in a RETURNING clause.
FossilOrigin-Name: 2e9bd94b9ad37c7e4123b7324f2fe42d3609a65af449eb8a0064057647709a73
2021-02-02 20:46:11 +00:00
709dd13927
Report an error if RETURNING is used for DELETE or UPDATE of a virtual table.
...
FossilOrigin-Name: bd5dee8425327fde0429043ce325b910f1b7951988d9a448a8eeeb713a46bc81
2021-02-02 12:01:22 +00:00
c9be863098
Allow the RETURNING trigger to exist for virtual tables.
...
FossilOrigin-Name: 2f244ab4a2ba2bdb608cf44ef02e00738ad58c10a76d9e4222dc843a17103d92
2021-02-02 00:16:15 +00:00
9e673ace5b
Improved corrupt database detection in balance_nonroot().
...
FossilOrigin-Name: 5d54d9fd406381383afdf10612bfd590afc4142215d9bca09e227e3aa5baa102
2021-02-01 12:39:50 +00:00
7baf3d411b
Modify RETURNING so that it does not return changes implemented by
...
cascading foreign keys or by triggers.
FossilOrigin-Name: 6e62470a737cbde7f3fdcd027b98eb0b3dd11d063c63501d3c18448e93f5959f
2021-02-01 01:57:55 +00:00
9407b6ef29
Mark an unreachable branch as ALWAYS().
...
FossilOrigin-Name: cb8b797a64f65fca01c5faaeb30cbe4a53b56b81e696d1b62a90362d7ef8f924
2021-01-31 16:45:10 +00:00
18e5607211
New opcode OP_ChngCntRow used to output the result of PRAGMA change_count.
...
Only this new opcode, and not OP_ResultRow, checks for foreign key errors.
Faster performance, and now also works with RETURNING.
FossilOrigin-Name: 154fc2b15465c7c92a1af0a93851421aec42a81bab54840a9701f2c78068e14e
2021-01-31 15:50:36 +00:00
662fe79647
When setting the number of result columns in a RETURNING trigger, be sure
...
to set that value in the top-level bytecode program, not in the immediate
caller of the trigger.
FossilOrigin-Name: 1f1ce7ceb9807d22efea496f33908040ee196a31cd192f27ec0fb3e23afb729c
2021-01-31 12:41:20 +00:00
28828c550f
Improved comments on the new code.
...
FossilOrigin-Name: a38f0c1d7c1d7635732ac370d8fbc7e6a2005378e4621da7bc4f51a2f99912d1
2021-01-30 21:55:38 +00:00
1832f2921d
Add an ALWAYS() to an unreachable branch.
...
FossilOrigin-Name: 6bb6de42b62acd35ade6c95a11bb4c9b35e7e9a24620731ae36364c4d5c3bc31
2021-01-30 16:16:42 +00:00
a8a64a078f
Chagne the OP_ResultRow opcode so that it does not cancel
...
pending statement transactions.
FossilOrigin-Name: fea91e3a511b14dafcc4da92c59188f927ec60ed91441335183da6b4e7866c1b
2021-01-30 14:17:18 +00:00
0166df0bda
Fix a obsolete assert() in the bytecode engine. Improved OOM detection
...
in sqlite3AddReturning().
FossilOrigin-Name: 138b10d54a83e1e7d5b3cdbe593a5073b05e632d1823e1b74d85835435b9ee3d
2021-01-30 12:07:32 +00:00
cf4108bbc6
Fix handling of an OOM condition in sqlite3AddReturning().
...
FossilOrigin-Name: 52204cd768f115d13249ff0e3a252b716620f7ad16a6962e1192a09137a78596
2021-01-30 03:06:19 +00:00
658f0a3679
Fix a memory deallocation problem that comes up when doing a RETURNING query
...
on a corrupt database. I think I fixed this before, but it got unfixed with
stale editor content.
FossilOrigin-Name: 02b1415efb7d9849499afe4e9dbf7e470484bf144d6ca3d28fdc38fc0ac10afa
2021-01-30 02:43:26 +00:00
343256b9b0
Another attempt to get trigger selection correct for RETURNING triggers.
...
FossilOrigin-Name: 1b8ed52275a54800df90682d694b482f55f26c6c4a420659f9a3b7bfc61e8abe
2021-01-30 02:34:47 +00:00
16d861ffc2
When running the RETURNING trigger, if it is tagged as a DELETE trigger,
...
do not use it as INSERT or UPDATE.
FossilOrigin-Name: 3c7a6e04ddde34961d8e9d0443913e572a80853cf14a8263cec19523c39ca744
2021-01-30 02:22:38 +00:00
ba71a8a01b
Test cases added. RETURNING works with UPSERT as does PG.
...
FossilOrigin-Name: f5698f96e27c9b8669ec6016bb9920ef7580c4146eb61d628a0f62be5135ce94
2021-01-30 01:30:26 +00:00
8f4e2e25c4
Better handling of errors in RETURNING due to corrupt database files.
...
FossilOrigin-Name: 6aa2a058d136d0b24d94c5cbe1ce447eb435c1a1c7cdce5e435f1548bb3f05e7
2021-01-29 22:33:05 +00:00
d086aa0a48
RETURNING works even if "PRAGMA count_changes=ON" is set.
...
FossilOrigin-Name: a9122d97577b239704cdee1a90a3b0dbff8bdf9dea2324d7315bd47238dcc8eb
2021-01-29 21:31:59 +00:00
dac9a5f7df
Allow "*" wildcards in the RETURNING clause.
...
FossilOrigin-Name: b0e3ae303db2a035583a05848ab7977e612d7e40c77e31ea9e0166de443c901f
2021-01-29 21:18:46 +00:00
b835247954
Working prototype.
...
FossilOrigin-Name: b7ef4dc21f187ff4ff679e823782535188c3814aa6ce720b3a01c6d3ba4ef9f5
2021-01-29 19:32:17 +00:00
drh