paulhorn/sqlite
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
22,612 Commits 1,696 Branches 387 Tags
version-3.35.1
Commit Graph

237 Commits

Author SHA1 Message Date
drh 44d441313a An alternative approach for fixing ticket [1c24a659e6d7f3a1]. 
FossilOrigin-Name: a2adae907a28e169e64cfe69d97d7b68cb94e6ba07d2dfa995e3fbc6672fafdd
 2021-03-14 19:55:40 +00:00
drh e58b2b4a80 Fix a bad assert in RENAME COLUMN. 
dbsqlfuzz 3f0a7245b69cd08617d7d7781ebaedb0fe765a93.

FossilOrigin-Name: f13e0d12f137cd6b4e83e92bd36652431d8416e6eed4797313e061f2e390d39b
 2021-03-08 17:17:38 +00:00
drh 747cc9425d Fix a possible NULL pointer dereference when applying a DROP COLUMN to a 
corrupt database schema.  dbsqlfuzz 419aa525df93db6e463772c686ac6da27b46da9e

FossilOrigin-Name: 349ccf58ae4bb770805066102fc8e9e478d4da1f7a6a728223bd74eabf7b7843
 2021-03-06 13:02:12 +00:00
drh 05edf729f7 Mark the NotUsed parameter to the dropColumnFunc() function as unused, 
to avoid a harmless compiler warning.

FossilOrigin-Name: 23459071091248e94202e609bb8031c3e34722b8ae8ff5a66851dcc528a2d2c2
 2021-03-04 19:44:01 +00:00
drh 7601294ad3 Rename the "struct SrcList_item" object to the more succinct "SrcItem". 
This is a symbolic change only.  The logic is unmodified.

FossilOrigin-Name: bfd5bf2c73110fcb36db9ba2a949ff516131fbd3e89325f88fe9f5c2b4ed87b2
 2021-02-21 21:04:54 +00:00
dan 578277c257 Fix another problem handling corrupt database files in the ALTER TABLE DROP COLUMN code. 
FossilOrigin-Name: 9edf2ddc4799c8830c4b7b91d7aacee50029a4b9db329fd4c5674fbedea33034
 2021-02-19 18:39:32 +00:00
dan f4a72788a4 Fix a crash that could occur in ALTER TABLE DROP COLUMN if the sqlite_schema table was corrupt. 
FossilOrigin-Name: 126ee1ec4f3565c0cccca98885fa3665a641ea3df251511de16eed2a1c396124
 2021-02-19 14:13:40 +00:00
drh 60fe2352f5 Omit an branch made unreachable by the improved error message from dropping 
the last column of a table.

FossilOrigin-Name: c5719fc5aa04c50bb01533f1cedb73dc80c4bf5315ff6a7206c8a10504afca8b
 2021-02-19 09:46:52 +00:00
drh 239c84fc62 Give a better error message on DROP COLUMN when attempting to drop 
the last column of a table.

FossilOrigin-Name: 5e1f362bc3e53c60f9e6f771346d10c6e6a6cb3ff1eec5608101f9c5d6d2a5a4
 2021-02-19 09:09:07 +00:00
drh c90fa01dbf Add a NEVER() to an unreachable branch in the DROP COLUMN logic. 
FossilOrigin-Name: 963f498ae64cf7530fb7a405fa476c411ad66523f62f5eefa5a16596cd19a481
 2021-02-19 02:30:02 +00:00
drh 0336140cd9 Add missing VdbeCoverage() macros. 
FossilOrigin-Name: 9bb720e6590482bc9c2fbb273738808209e9651710dbee7572b0348cadf87e68
 2021-02-18 23:53:47 +00:00
drh dcc29e0d1d Enhance renameParseSql() to better handle OOMs. 
FossilOrigin-Name: 68bcde7ab57b2d4bdcfb2f6c7134a0b01a504b2e7cdf6ee5bf0df70fb4a517b0
 2021-02-18 23:03:50 +00:00
dan 678f3b33cc Fix DROP COLUMN so that it works even if the user has registered an authorizer callback. 
FossilOrigin-Name: e5f144182bbb3ba10c77151cf63c8bddf86374049fb6866387f85e335df298cb
 2021-02-18 20:27:46 +00:00
dan 16953469a6 Fix a problem with schema error detection when processing ALTER TABLE DROP COLUMN commands. 
FossilOrigin-Name: 565a6fd0c95b438fea7bf84913b38de1718117e16e0d685534a8650e1dc8421b
 2021-02-18 19:25:44 +00:00
dan c2a878ed0a Fix a problem with OOM error handling in the new code on this branch. 
FossilOrigin-Name: ea999c9db59e4193b306a2e1b15fc94f8f04cb05e852bb0d068b7d5243a0849b
 2021-02-17 20:46:44 +00:00
dan 6a5a13df97 Fix various issues with the changes on this branch. Add test cases for the same. 
FossilOrigin-Name: 10538ec6fc1642dfc2ca6cef06ce6cb9e124847b421ccf01f5842064fad379ab
 2021-02-17 20:08:22 +00:00
dan 6e6d9833cc Add experimental implementation of ALTER TABLE DROP COLUMN. Only some cases work so far. 
FossilOrigin-Name: f0217937d7306fb595727e61e871e8b03d8c881d339a0865bfd0117d90d42e4e
 2021-02-16 20:43:36 +00:00
drh 351ae772a3 Ensure that the ALTER TABLE statements return 0 for 
sqlite3_column_count().

FossilOrigin-Name: 29c1932a47cd46c2585ebbf937c03544a8a355014776129662789e15db9ed4de
 2021-02-15 13:17:19 +00:00
drh 37114fbfcc Change the unions of the Table.addColOffset field from characters to bytes. 
This makes the query that implements ALTER TABLE ADD COLUMN more complex and
slightly slower, but also makes CREATE TABLE statement parsing faster by
avoiding a call to sqlite3UtfCharLen().  Since, CREATE TABLE parsing is far
more common than ALTER TABLE, this is a net win for performance.

FossilOrigin-Name: 6f25f2529f1495a26129d7d407979906e4962b2de351f901d41cb037d05ba780
 2021-01-01 20:04:34 +00:00
dan 7a39faecc2 Update the ALTER TABLE command to correctly handle UPDATE ... FROM statements within trigger programs. 
FossilOrigin-Name: 3e6af890406b58da1c4aebec4d483be7ab0fdb589ef7a4c4e987d6bde18d6b97
 2020-10-31 16:33:01 +00:00
drh a3e6495970 Improvement on the previous fix. 
FossilOrigin-Name: f6cffa2d50bfebe5b025f412b7a49b7fdafb798aaf1ddc80e6656ccd1f012a7f
 2020-08-12 16:19:12 +00:00
drh b6a74caf93 Fix an assertion() fault in ALTER TABLE found by OSSFuzz. Test case in TH3. 
FossilOrigin-Name: 41de742c5713ab1a0c0c15c44af3ffac40bbc527ae2dc11d829ba9773eb4c84a
 2020-08-12 15:39:43 +00:00
drh a7c74006a0 More harmless compiler warning fixes. 
FossilOrigin-Name: 4c0d208c455abb983217a6dfea7634f677f8360fb57857e1421334fe7a5a23e2
 2020-07-18 18:44:59 +00:00
dan e7877b2d6b Support UPDATE...FROM statements in trigger programs. 
FossilOrigin-Name: 4f6d8d0ebf40029218a1d3b05ea657c0c5953b01c6f0b6a628465aa44c67e7f3
 2020-07-14 19:51:01 +00:00
drh 1e32bed3c1 Further refactoring of the schema table name. 
FossilOrigin-Name: 9536fa0ae0c1ae6e2e98d2fa11e5acda7f3c9b8ca5061b6f7f8cae63a11d936b
 2020-06-19 13:33:53 +00:00
drh 346a70ca1e Provide "sqlite_schema" as an alternative name to the table that holds the 
database schema.

FossilOrigin-Name: 61782a7ae3c25cf59d7a676cb295eb024d17c46e532ae78c6fe871a91d712fa9
 2020-06-15 20:27:35 +00:00
drh 3d863b5e4e Do not allow a virtual table to be renamed into the name of one of its 
shadows.

FossilOrigin-Name: eca0ba2cf4c0fdf757bae19c6397a48245adb99e8017ddc28f01804072a30b2c
 2020-05-14 21:16:52 +00:00
drh 9e5fdc41c1 Release some restrictions on columns added by ALTER TABLE so that they 
only apply if the table contains one or more rows.

FossilOrigin-Name: 3a16c0ce4d8851f79f670d94786032c8007619154ece44647dc9cc5b1f9654ff
 2020-05-08 19:02:21 +00:00
drh 2d99f95721 The ALTER TABLE fix of check-in [7e5ad8e0ab7ee91a] is no longer needed due 
to the changes at check-in [4cf8721f5ceb1fda].  But, we keep the defense
in place as an assert() for extra safety.

FossilOrigin-Name: 230556e859536bbadf0daf8133a9a01ef4f03148b3296723e37bad66e3fc3d82
 2020-04-07 01:18:23 +00:00
drh d44390c8c5 Performance improvement for column name lookup. 
FossilOrigin-Name: 1e4b6a93987cdfbf829e2ff35ef417c290625f2894ad11949e301af518f1fb44
 2020-04-06 18:16:31 +00:00
dan fb99e388ec Fix a case when a pointer might be used after being freed in the ALTER TABLE code. Fix for [4722bdab08cb1]. 
FossilOrigin-Name: d09f8c3621d5f7f8c6d99d7d82bcaa8421855b3f470bea2b26c858106382b906
 2020-04-03 11:20:40 +00:00
drh 9fc1b9af36 NEVER() and ALWAYS() macros tagging unreachable branches. 
FossilOrigin-Name: 34b877742ef78e9bb3f16815180f4ad9cd722beb1d610f713400a3b25d68aa9b
 2020-01-02 22:23:01 +00:00
drh 5f6a2ed7f2 Merge recent enhancements from trunk. 
FossilOrigin-Name: 39d55579376906f212271ce9b2d367e3ad029fb173f22c7253312b467970208a
 2019-12-31 14:49:10 +00:00
dan 394aa710f2 Fix a potential problem with ALTER TABLE commands on schemas that contains a triggers or view featuring a sub-query that uses an ON clause with a join that is not a LEFT JOIN. 
FossilOrigin-Name: 365dd8b663d5a28af33556b2b3820c6b5482114ef741a1d82b55c6e154f3043a
 2019-12-20 14:18:29 +00:00
drh b2ab3dcff0 Fix harmless compiler warnings. 
FossilOrigin-Name: 2bbd014c900e0d71fd30ec647739b82c5dc3aa237a0203f5a1db50593dae199e
 2019-12-20 14:08:34 +00:00
drh 1548d5276f Do not continue an ALTER TABLE tree walk of a subquery if a prior error 
is seen in the tree.  Report the problem immediately, without continuing.

FossilOrigin-Name: 01ca865f31c0c817ede7f357401ef76cf311ae662397908464f53e1c147f5b6b
 2019-12-20 12:55:21 +00:00
drh 646975c521 Clean up the ExprList that holds the names of columns in a CTE before checking 
for unused references in the ALTER TABLE implementation.

FossilOrigin-Name: 8223e79f987feda5c8e51ec52cec6798cca16d070b10558939e2888ca1a25b8e
 2019-12-17 12:03:30 +00:00
drh c4938ea2ba Tie up the loose ends in the ExprList size reduction. 
FossilOrigin-Name: 59d0f3afe5249a2a6453fe7bc810c2c7beb896d3800174c7c90f9304c0b1ad88
 2019-12-13 00:49:42 +00:00
drh 41cee66848 Change the name of the Expr.a.zName field to zEName, so that it has a name 
that is distinct from other fields and variables and is hence easier to
grep for.

FossilOrigin-Name: d3783357f8fa76c42a86f12b214522f0388c37773c36ab8c5ce0623abbc4436a
 2019-12-12 20:22:34 +00:00
drh 2bc5cf9ae9 Add a NEVER() to the ALTER TABLE fix in check-in [1d2e53a39b87e364] 
FossilOrigin-Name: c7309ed3c7588c7e51e09418bf5cfd4611539b44c39cef9ed4ae0e385bae7625
 2019-12-09 19:29:10 +00:00
dan 38096961c7 Avoid infinite recursion in the ALTER TABLE code when a view contains an unused CTE that references, directly or indirectly, the view itself. 
FossilOrigin-Name: 1d2e53a39b87e364685e21de137655b6eee725e4c6d27fc90865072d7c5892b5
 2019-12-09 08:13:43 +00:00
dan e6dc1e5b70 Fix a problem in ALTER TABLE that could occur if an index, view or trigger in the schema features an expression of the form ((SELECT ...) IN ()) where the SELECT statement uses a CTE. 
FossilOrigin-Name: 7e5ad8e0ab7ee91a5ccb19a9654d6a036233f74d2fdc45f7315feb3d9d035fd4
 2019-12-05 14:31:43 +00:00
drh d63b69b8a2 Ensure that an ALWAYS() in the rename logic really is always true, even 
for faulty inputs.

FossilOrigin-Name: 54410f0e7710542d5159d0449898598d2b7f7676bfd993644ca47da1bf1fcdac
 2019-12-04 15:08:58 +00:00
dan 8f4076223d Fix an assert() failure that could occur in ALTER TABLE code when the schema contains a view that uses a CTE. 
FossilOrigin-Name: 75b04a4b0d2e65bfcd02cf4e0b6d8f1954957c590814a9b8f9a9ee2adc2ec022
 2019-12-04 14:26:38 +00:00
drh 070ae3beea Break out the test for writable shadow tables into a separate subroutine. 
FossilOrigin-Name: 8ad34d36a141fa8f5d9bd784dfeb892c983897a6dc6b867607cc668508acf944
 2019-11-16 13:51:31 +00:00
drh 035f6d909f Do not allow ALTER TABLE ADD COLUMN for a STORED column. 
FossilOrigin-Name: 42fc08bc1528a34a603c2c085b515766a8d33ae7ea0350a52b0ca24b94ebcbc5
 2019-10-24 01:04:10 +00:00
drh b9bcf7ca60 Refactor names of column index transformation functions, for clarity. 
Get generated columns working with ALTER TABLE RENAME COLUMN.

FossilOrigin-Name: 27ab41c9102e7801ff829488fc123a8040da008bef373d6704efbe2f93e1da90
 2019-10-19 13:29:10 +00:00
drh c27ea2ae8d ALTER TABLE is able to add a VIRTUAL column. 
FossilOrigin-Name: 120c6b78cb51532f783014605f1107d40b2e4f54e3852fb1f8f167d0c0b78c69
 2019-10-16 20:05:56 +00:00
drh 92a2824cc6 An improved fix for the dbsqlfuzz-discovered ALWAYS() failure following OOM in 
sqlite3ExprCollSeq().  This time with a test case (engineered by Dan).

FossilOrigin-Name: 907f7965b335d8d5441f2e386bb190d1f93ffcd45ca98d2d1c621dede491fc5e
 2019-10-09 15:37:58 +00:00
drh efb02281a4 Change sqlite3SelectDup() to always return NULL if an OOM has occurred. 
FossilOrigin-Name: 01ba4641ab436c6065c8725908fc0913f2abded4ea62e004b7534e0116b9451a
 2019-10-09 15:00:37 +00:00