bc91738e66
Add a C-source spell-checking facility. make misspell (on Nix)
...
FossilOrigin-Name: 26c1bb4bd9e9f56613c3aa87407a7f562fd4ebde5bfd6dece02078001d9a45f8
2023-06-07 08:40:31 +00:00
b53e0992b2
Enhance an assert() to impose for tighter constraints on the operation of pcache.
...
FossilOrigin-Name: 42105eb43a916a7cd839fa6c582eaffaef17f50b23c3e05142400c379feb73c7
2022-09-07 20:11:22 +00:00
8c983ddb67
An improved technique for ensuring that the Rekey() operation does not
...
overwrite an existing page number. This approach does not change the
semantics of the underlying pluggable pcache and it is easier to prove
correct. This replaces the changes at
[aadd38f99a3e5abc] and [81cff9f1955874aa].
FossilOrigin-Name: 7dbddde79e3ca1b81e00288616fc27434698ce6dcb47714728fce8602ae91f45
2022-09-07 19:28:18 +00:00
4e9bf5ace3
Enhance the pcache1 implementation so that during an xRekey operation if
...
another page already exists at the destination, that other page gets moved
to the source key.
FossilOrigin-Name: aadd38f99a3e5abcf9bef49f4367752f163cc79500a28f812bb71969d7de419c
2022-09-02 14:29:54 +00:00
9c3a114ca0
Enhance the b-tree page sorting code to ensure that sqlite3PagerRekey() never
...
overloads a page number and uses only the PENDING_BYTE page for temporary
storage.
FossilOrigin-Name: 5007742886bd20de20be3973737cf46b010359911615eb3da69cd262bd9a2435
2022-08-31 15:04:42 +00:00
78d15f097a
Improved comments in pcache1.c. No changes to code.
...
FossilOrigin-Name: dd017bb1b3e31c7692d29dc4865d6bda871e429978c8738a39160d0114e5bf9b
2022-08-30 16:54:41 +00:00
c8e9f6818b
Omit the (undocumented) SQLITE_PCACHE_SEPARATE_HEADER compile-time option.
...
FossilOrigin-Name: 60947da687d525e72e62bcddcdf4c5c819818855074cc318c9ee656e83897aef
2022-08-09 14:28:54 +00:00
f9d349a80d
Fix a compiler warning in pcache1. Reduce the maximum size of a pcache1
...
cache to 2147418112 pages.
FossilOrigin-Name: 4bc93658aa563f2fa84f7f85f7f9f336dc80425640140c0fc2aec4a3606fad48
2021-08-09 19:54:27 +00:00
8a72882425
Ensure that the pcache1 cache size does not get so big that it overflows
...
the integer that is keeping track of the cache size.
FossilOrigin-Name: bf9d70fc2fde06a3f132270a26d4abe321687169066aff26ad9e92757c7f9ee4
2021-08-09 18:07:06 +00:00
1e06c70eb0
Initialize extra field in PgHdr1 to fix an msan complaint.
...
FossilOrigin-Name: 4cb2ea5795b0c0678665fd89bd560209beaab8a756fe00335dbfd07493b0542d
2021-02-28 08:24:56 +00:00
0f1fa5de04
Patch to the page cache to avoid harmless pointer arithmetic that due to bugs
...
in the STD-C spec is technically UB. This is to fix a harmless UBSAN
complaint that OSSFuzz is hitting.
FossilOrigin-Name: c29fc21288e37f81a1617c5e2961c575d3bca6a1d1b013b2e0a99774afb1dcdb
2019-12-13 21:24:46 +00:00
55f66b341a
Add new assert() statements in an attempt to help static analyzers avoid
...
false-positives.
FossilOrigin-Name: 9e66458592d40fbd96ea5f21339573110ca1cfe328238a020c9420a87d35dd72
2019-07-16 19:44:32 +00:00
a082cd75a1
Fix a race condition that could occur in SQLITE_ENABLE_MEMORY_MANAGEMENT builds when two threads simultaneously open the first two database connections in the process.
...
FossilOrigin-Name: 5ea3f6fc88cf66824128aa64f777a7abb4f6ed55f214d7a135f36e306a32487c
2019-07-04 16:05:26 +00:00
d4de9f7b1e
Fix an obsolete comment and other minor issues from code inspection.
...
FossilOrigin-Name: cd084427319394386844d6651479256a2fd57a412fccb79ba53172ce76693eb1
2019-04-14 00:34:20 +00:00
e385d33a29
Ensure all bytes of the PgHdr1 structure are initialized. This avoids a valgrind error when running corruptI.test.
...
FossilOrigin-Name: a505e34d4ec31159a4508ec827fcffed0cf3bd5ea5ef0ac293016da02367a53a
2019-02-06 20:49:49 +00:00
1757fed87f
Adjustments to the page cache to try to avoid harmless TSAN warnings.
...
FossilOrigin-Name: 383437be276719ac1c72688ae81017c63907ac561f2ffb8e42c43b012248f294
2019-01-09 14:49:58 +00:00
d7a5e49840
Back out the expansion of the temporary buffer size from
...
[32754ca6f86da816] and replace it with an explicit test for buffer
overreads.
FossilOrigin-Name: 8ba3d9f38090c4bbbcffba1930e5c26f69ff61f49b72a4a5a59253d37341380f
2018-12-14 16:20:54 +00:00
d6401e869b
Expand the size of the temporary page used during btree rebalancing by a
...
few bytes, to avoid problems with small buffer overreads that can occur
on corrupted database files.
FossilOrigin-Name: 32754ca6f86da8165e274f98f35fc3df3aebd273e9da08387e2d0c3c89abda0f
2018-12-14 13:35:48 +00:00
de72d2a81a
Remove two lines of unnecessary code, for a very small performance increase
...
and size decrease.
FossilOrigin-Name: 15824ccda0f110794a479b58fbf36082d8c383f34bae9dc0921d96547fb37869
2018-12-03 01:58:02 +00:00
26505e5f51
Follow-up to [0bf0fd242b93c3bd30]: only reset the pager when adding a
...
new codec, not when overwriting an existing codec. Also, improve a
comment in the pcache1 subsystem.
FossilOrigin-Name: 5c040fdb013d178e5dffa300621eab91b92beb085ffb9ef2ba08f6bf1dd4013e
2018-11-28 11:09:09 +00:00
617b7b42e3
Small performance optimization in pcache1.
...
FossilOrigin-Name: ffd437da9541f8a2792e3e07c0a43f388f856fdc211fe42755eb51bfa5995d9f
2017-08-30 04:44:59 +00:00
52df6f5e5c
Avoid unnecessary mutexes in the pcache1 implementation in the common case
...
where no auxiliary page cache memory is configured.
FossilOrigin-Name: 1ba051e34d7512ab5e8fc969c1b5aaaf827b8e6493ba4235895257aca78b500f
2017-08-28 16:11:05 +00:00
eabb67fb61
Microoptimization in pcache1.c makes the code slightly smaller and faster.
...
FossilOrigin-Name: 422cd9f39403feeacd70133c7a147e23572c75d617ac564344f016ae6611162c
2017-08-05 15:49:03 +00:00
4eb8d7fa89
Slightly smaller and faster implementation of pcache1InitBulk().
...
FossilOrigin-Name: 06c2b685e15b3ee045a3e7ea018701392771c7664e59a51c9aba87cdefeb37af
2017-03-29 17:06:14 +00:00
bf96228754
Fix the sqlite3_release_memory() interface so that it works even if
...
SQLITE_DEFAULT_PCACHE_INITSZ is non-zero.
FossilOrigin-Name: 5d902b7fea3144bf57f02aca87b9795fdcec4774310ade6ef01f37d206c3d74f
2017-03-29 15:18:40 +00:00
989412a1cf
Take care to avoid integer overflow when doing the initial page cache
...
allocation with an excessively large cache_size setting.
FossilOrigin-Name: 4d66ac98deaa85218be7ff0eb254f78b96d8e8d4
2016-10-13 12:56:18 +00:00
f5dbe7f8d8
Tweaks to pcache1TruncateUnsafe() to make it slightly smaller and faster and
...
easier to test.
FossilOrigin-Name: 059f4e2efefb7b9deaf539110c19bceaeb10c6ce
2016-08-10 15:02:49 +00:00
d9fabbcc5b
Fix pcache1TruncateUnsafe() run faster for the case where iLimit is
...
very close to iMaxKey.
FossilOrigin-Name: b07a26df06a2ffb946ff8a1cc7f43eaf701a94b5
2016-08-10 11:50:12 +00:00
97a7e5e68c
The pcache and the built-in VFSes should not use mutexes when
...
SQLITE_CONFIG_SINGLETHREAD is set.
FossilOrigin-Name: 12418b100196abbfbfb85e0ab4bb6b1cbf335df7
2016-04-26 18:58:54 +00:00
9493cafe6f
Fix harmless compiler warnings that arise with -DSQLITE_OMIT_LOAD_EXTENSION
...
FossilOrigin-Name: 65ba2f0b465a1493de6e467f55e0300ac3fb08e1
2016-03-17 23:16:37 +00:00
8b0ba7b0b8
Make greater use of the SQLITE_WITHIN macro.
...
FossilOrigin-Name: f2fc3aede55c8fa0351697f9f5ce4e544334c9af
2015-12-16 13:07:35 +00:00
a6082f699e
The first argument to SQLITE_CONFIG_PAGECACHE, SQLITE_CONFIG_SCRATCH, and
...
SQLITE_CONFIG_HEAP must always be a pointer.
FossilOrigin-Name: 5e14cadff09d7425c8e1cc5e817f2b0609e52a46
2015-11-26 22:12:41 +00:00
b02392e6f0
Change sqlite3StatusSet() into sqlite3StatusHighwater() so that only the
...
highwater mark is recorded. This gives a small size reduction and
performance improvement.
FossilOrigin-Name: 6422d223dd10018703c6b083d29a3c35c837fc97
2015-10-15 15:28:56 +00:00
8faee877cb
Fix compiler warnings.
...
FossilOrigin-Name: 5c31ee62a196b914673384a611534fd778dc64b0
2015-09-19 18:08:13 +00:00
0b19c96935
Fix a potential NULL pointer deref in the testing logic of pcache1.
...
NB: The -DSQLITE_TEST compile-time option is needed to hit the problem.
FossilOrigin-Name: f5580f08538636ffb1367e717a33756288ccddde
2015-09-10 19:22:25 +00:00
8820250e8d
Fix a possible NULL pointer deref when using SQLITE_ENABLE_MEMORY_MANAGEMENT.
...
FossilOrigin-Name: 89bfdbfe943adce8e02c84ede014fcfed504c5d3
2015-09-09 19:27:10 +00:00
92af02c939
Simplification of the LRU list handling in pcache1.
...
FossilOrigin-Name: 05a3a2cd140587265b5427d23c93c5be1f39e199
2015-09-04 04:31:56 +00:00
95a0b37156
Change the pcache module to keep track of the total number of references to
...
all pages rather than the number of pages references, for a performance
improvement and size reduction.
FossilOrigin-Name: f00a9e1e998c4bd249a45444dc2d71a7e4903b8b
2015-09-03 20:43:55 +00:00
3c0c43191a
Reduce the number of calls to sqlite3BeginBenignMalloc().
...
FossilOrigin-Name: 0bee6583665782fac5d9e82bdf19b6f07e7bd03f
2015-09-01 19:51:37 +00:00
0dfbe064de
Fix typo in comment. No changes to code.
...
FossilOrigin-Name: 7b8d17dd840f64dac9a018a4547a97de799e94ab
2015-08-21 12:37:49 +00:00
939d4bcd77
Fix harmless compiler warnings.
...
FossilOrigin-Name: 9a592cf91c74b369bacf6a0e69d45f3e73dfdbce
2015-07-16 18:37:53 +00:00
957026ac78
Defer the bulk pcache1 memory allocation until the first page allocation
...
request. Limit the size of the pcache1 bulk allocation to the cache_size
setting. Deallocate the bulk allocation on a sqlite3_db_release_memory()
request, if the bulk allocation is completely unused.
FossilOrigin-Name: b79a4affe44bd0c8e155cae19f3f62c715684cd6
2015-07-16 18:18:19 +00:00
7b341e6f99
Comment fix. No changes to code.
...
FossilOrigin-Name: c1e2ed0ef4d3436d19d3203c5fb553caac53659e
2015-07-08 14:13:44 +00:00
52d9f40b7d
Do not do the bulk pcache1 allocations if SQLITE_CONFIG_PAGECACHE specifies
...
a global page cache buffer.
FossilOrigin-Name: 75d98dae676996a05e97b09b19e34463e8f30d51
2015-07-08 13:40:50 +00:00
fd5ae9649c
No need to test sqlite3GlobalConfig.bCoreMutex when SQLITE_THREADSAFE==0.
...
FossilOrigin-Name: 26db0fee06947d75621237a641b9652b312b3b37
2015-07-07 15:14:16 +00:00
c54357cc2a
Simplify the page recycling condition in pcache1. Fix test cases to work
...
with the latest changes.
FossilOrigin-Name: 5b60df5503f61922326b3e10e94aa197b17afe4b
2015-07-07 14:06:18 +00:00
db7ae89d5b
A unified cache is now only used for SQLITE_ENABLE_MEMORY_MANAGEMENT, or if
...
SQLITE_CONFIG_PAGECACHE defines a shared start-time page cache buffer and the
application is single-threaded.
FossilOrigin-Name: d5ff1d69054d51a55eff6e1979971822db7f8f30
2015-07-06 20:57:22 +00:00
ee70a84ea7
Enhance separate pcache1 to allocate a block of pages from heap on startup,
...
if possible, for a 5.2% performance improvement.
FossilOrigin-Name: aa7341c8736732a0a59f6688cc34e78be02a7bfc
2015-07-06 18:54:52 +00:00
01c5c00c12
Preserve the number of requested PAGECACHE pages even if the memory pointer
...
or size is zero. Enhance the pcache1.c header comment to explain the memory
layout of a page cache line.
FossilOrigin-Name: dacb2a615ce1c0573baf4518000454038745cf2a
2015-07-04 18:15:04 +00:00
95c91e145a
Use tail recursion in pcache1Unpin() to get a small size reduction and
...
speed improvement.
FossilOrigin-Name: fde70472aebc09b34a517131f676e6847d02b747
2015-06-29 00:21:00 +00:00
larrybr