22ace89179
Fix some problems to do with OOM conditions in vdbesort.c. Some problems remain.
...
FossilOrigin-Name: 2f94f9ce9bf11f1599bbc640b3fc8c15da588416
2014-04-15 20:52:27 +00:00
1a088a8ef5
Fix further code and documentation issues in vdbesort.c.
...
FossilOrigin-Name: d03f5b8622d304f029f73c7cd0bee3182a81d081
2014-04-15 19:52:34 +00:00
9c1586ec7c
Allow the sorter to begin returning data to the VDBE as soon as it is available, instead of waiting until all keys have been sorted.
...
FossilOrigin-Name: cb0ab20c48962cdee03115efa93d7d501780ac73
2014-04-14 19:23:18 +00:00
f77ceba594
Improve performance in single-threaded mode by having the final merge pass keys directly to the VDBE, instead of going via a final PMA.
...
FossilOrigin-Name: 02610cd9b77caa2c181210056088beb3ad6ce30f
2014-04-14 18:41:21 +00:00
92a20dde1f
Minor fixes so that builds with SQLITE_MAX_WORKER_THREADS=0 work.
...
FossilOrigin-Name: e400bbbf26cdfe88f6cb231e96cdcddb9a6bcc0f
2014-04-14 08:45:32 +00:00
be3018c18f
Improve use of multiple threads in sqlite3VdbeSorterRewind().
...
FossilOrigin-Name: e1bdc4b810907cc0e55e0c923c8ebc777068cfe0
2014-04-14 07:30:39 +00:00
82a8a9f120
Fix many issues with new code.
...
FossilOrigin-Name: 62c406a042d7246f6df6b943421182a88483b2e3
2014-04-12 19:34:44 +00:00
4be4c406fa
Avoid having the sorter merge too many PMAs at a time when incrementally merging data following a SorterRewind().
...
FossilOrigin-Name: 98bf0307b121b0776a7170108cc8d3f948a7ebfe
2014-04-11 19:43:07 +00:00
d30ab3d9dd
Experimental multi-threaded sorting changes to allow the sorter to begin returning items to the VDBE before all data is sorted.
...
FossilOrigin-Name: f9d5e09afaf64d68a0e461c1c2f38179bcea4b1f
2014-04-09 20:04:17 +00:00
bf20a35d5f
Fix harmless compiler warnings.
...
FossilOrigin-Name: e54dded2012f0ab486ee138e9bd57c528af33980
2014-04-04 22:44:59 +00:00
f7da5555da
Fix typo in a Windows threading support routine.
...
FossilOrigin-Name: 5e3dfa27c71a666e122e3cf64897038ff8424800
2014-04-04 21:40:38 +00:00
85462ed939
Merge the latest trunk changes into the threads branch.
...
FossilOrigin-Name: 39ac79cffe716f88af0871bdd206231b6a6511ff
2014-04-04 18:37:36 +00:00
853546d047
Merge changes to the query planner that strive to ensure that any index
...
usage that is a proper subset of some other index usage always has a slightly
higher cost.
FossilOrigin-Name: 683dd379a293b2f330e1e4cd746f190527fe48ee
2014-04-04 18:20:35 +00:00
1fb6a11072
Ensure the "PRAGMA journal_mode=WAL" works coming from any other journal_mode
...
with ATTACH-ed databases.
FossilOrigin-Name: e54330b43127e46fc6494748cbb353a6fc91cfd7
2014-04-04 14:12:52 +00:00
8daefc2af0
Add test file sort3.test, which should have been part of commit [9d3351b8d7].
...
FossilOrigin-Name: dceed2c803fca23c83c02c448d5ae7c4698efee1
2014-04-04 07:52:44 +00:00
6b5d4759ce
Change vdbeSorterExtendFile() so that it makes a best effort to create the
...
PMA file of the desired size, but does not return an error if unable.
FossilOrigin-Name: 217814bc4b53fab7bdad433e24e8aef8998c38fe
2014-04-04 02:13:26 +00:00
1aca5caa88
Merge all recent changes from trunk.
...
FossilOrigin-Name: a0910079adde95245680dee59b43613b60903f10
2014-04-03 16:42:21 +00:00
c438df1be0
Use OP_Copy instead of OP_SCopy when moving results out of a subquery,
...
to prevent the subquery results from changing out from under the outer
query. Fix for ticket [1e64dd782a126f48d78].
FossilOrigin-Name: d5513dfa23baa0b0a095aaf17d19aacd30dcef61
2014-04-03 16:29:31 +00:00
8930c2ab0c
Fix an integer overflow problem in the sorter.
...
FossilOrigin-Name: 9d3351b8d713232133dad149c73fb2a27c72abb1
2014-04-03 16:25:29 +00:00
831116d164
Fix a typo in the "Synopsis:" comment for the OP_VFilter opcode.
...
FossilOrigin-Name: 48ecdd4aff03741f96c070dced69c3c273b652cb
2014-04-03 14:31:00 +00:00
6e4cc55e1f
Fix minor errors causing compilation to fail with SQLITE_MAX_WORKER_THREADS set to a value greater than zero.
...
FossilOrigin-Name: 0561272abf357a2f4709f6c02866e570d19cd344
2014-04-03 14:29:08 +00:00
a634fb1577
Refactor local object and method names in vdbesort.c so that their names
...
more closely reflect their actual use.
FossilOrigin-Name: d284e30eb1db144965fa85566e4234e30464350b
2014-04-03 02:54:27 +00:00
54d0d2dd9a
In the command-line shell, run set writable_schema before running the
...
".clone" command.
FossilOrigin-Name: 9d2ae6342c8afa904bec591ebe134ff7f536b71c
2014-04-03 00:32:13 +00:00
ac4f0039c0
Add a big introductory comment to vdbesort.c explaining its operation at a
...
high level. Also adjust some symbolic names and fix other comment issues in
that file.
FossilOrigin-Name: eef60f1bf54fcdc7b32f96ebb87a9a0bf0776e8b
2014-04-02 18:58:49 +00:00
dd95d30f82
Fix some problems with OOM handling in vdbesort.c.
...
FossilOrigin-Name: 47e702bd8392bc50c4edaf6a2c8c499af87b520e
2014-04-02 15:15:25 +00:00
8d8f56296b
Change the name of the SorterThread object to "SortSubtask" to avoid confusion
...
with the SQLiteThread object.
FossilOrigin-Name: 4ee2d910fbbed8d4def15e4e99ee225839f3a739
2014-04-02 14:38:14 +00:00
fad9f9a8a6
When sorting data for a CREATE INDEX statement in single-threaded mode, assume that keys are delivered to the sorter in primary key order. Also fix various comments that had fallen out of date.
...
FossilOrigin-Name: 821d1ac4504243fa13b9e3c0d56361ad9fb80d78
2014-04-01 18:41:51 +00:00
578e1ca8d7
Even if compile time option SQLITE_MAX_WORKER_THREADS is set to one or greater, set the default number of worker threads to zero. Distribute data more evenly between threads in sqlite3VdbeSorterWrite() to improve performance when sorting large amounts of data. Add new test file sort2.test.
...
FossilOrigin-Name: 643c86a056168e39fcb7f39b8a72731f1eb246db
2014-04-01 15:38:44 +00:00
38fdead890
Fix a problem with OOM handling in the sorter code.
...
FossilOrigin-Name: 59cd5229e2b5be5272cf57c7e7d09e97d16a5425
2014-04-01 10:19:02 +00:00
d3c156638a
Remove an unnecessary conditional.
...
FossilOrigin-Name: 7473c4dfc10a47594affa6f4e071a08dc8838c0c
2014-03-31 20:05:20 +00:00
b3f56fdb69
Add the SQLITE_MAX_WORKER_THREADS compile time option. And the SQLITE_CONFIG_WORKER_THREADS sqlite3_config() switch.
...
FossilOrigin-Name: 2774710df8cd2bfaca49888c69f1b01c0ddadf9a
2014-03-31 19:57:34 +00:00
3fb183d2f7
Also make sure an index that is a proper subset of some other index has a
...
higher cost than that other index. Add test cases.
FossilOrigin-Name: b7830d232b073a197aa1092e78cb24e88cb10fd3
2014-03-31 19:49:00 +00:00
53cd10afcd
Make sure that an index that covers a proper superset of the WHERE clause
...
terms of some other index has a lower cost than the other index.
FossilOrigin-Name: ea8b0910040198751551b0b960e6b783913607df
2014-03-31 18:24:18 +00:00
b663587890
Avoid a (harmless) buffer overread that is possible on an OOM when
...
MEMSYS5 is engaged.
FossilOrigin-Name: b3296267fb67b9f59719a37093253062edde3746
2014-03-31 13:42:42 +00:00
7a4b1642a7
Experiments in picking better query plans, especially when the usage of one
...
index is a subset of another.
FossilOrigin-Name: 8f869ca7a6eaa9ca7a08102290e6c606735f9090
2014-03-29 21:16:07 +00:00
853c4a7621
Fix a broken assert() in vdbesort.c.
...
FossilOrigin-Name: 18d1b402f2dbe78f1a1113bb356b710e348365ef
2014-03-29 10:01:58 +00:00
e7c84cc7e3
Fix a problem in vdbesort.c causing spurious SQLITE_NOMEM errors when using memsys3 or memsys5.
...
FossilOrigin-Name: a683c05f6250389e84b980b16559e162ba1a27c2
2014-03-29 09:34:45 +00:00
ff9fce4d60
Add the optimization to avoid some unnecessary calls to sqlite3VdbeRecordUnpack() added to the trunk by [707ea170b3].
...
FossilOrigin-Name: fc4d04e6b039ea5aeb47739e38c5926e63a4b01b
2014-03-29 06:27:35 +00:00
2f17001521
Merge latest changes from orderby-planning branch.
...
FossilOrigin-Name: 4c7fb5423430f3b936befaa7c309f8e1968ee7d8
2014-03-28 19:18:16 +00:00
7c8e9c78c8
Merge the latest changes from trunk.
...
FossilOrigin-Name: 3047a25f1c41e83f0b4772f7c36fbfec0f12dc7e
2014-03-28 18:35:39 +00:00
70c93204ea
Disable the wal64k.test script for non-unix systems since it depends on
...
unix-only features.
FossilOrigin-Name: 27deb6e49bcc76714dbdc61b34748603155ac770
2014-03-28 14:41:35 +00:00
36ed03428d
Fix a harmless compiler warning.
...
FossilOrigin-Name: a4e47150f32b3a4120b1f89ccc66d633d829e3bb
2014-03-28 12:56:57 +00:00
a1f7c0a21c
Enhance the sqlite3VdbeRecordCompare() routines so that if they encounter
...
database corruption, they will set the UnpackedRecord.isCorrupt field and
return 0. The sqlite3BtreeMovetoUnpacked() routine detects this and returns
SQLITE_CORRUPT, causing the corruption to be reported back to the top-level.
FossilOrigin-Name: 7fa85eaaaf6d211378620d728a759fdfe30a15b0
2014-03-28 03:12:48 +00:00
6971952c65
Instead of allocating a single large buffer at the beginning of each sort operation, start with a small buffer and extend it using realloc() as required.
...
FossilOrigin-Name: 81987c8ceb64f051528a6ca42673821d9ab7c0ff
2014-03-27 19:25:02 +00:00
27de5c5cb6
Minor cleanup of the code in the query planner that computes the costs
...
estimates for the various plans. There are no changes to the costs at this
time. But the code is slightly more readable now and that might facilitate
future enhancements.
FossilOrigin-Name: 9b4d7226bcee38be5ac68a54bee03b4179cb69fc
2014-03-27 18:36:34 +00:00
face087212
Use xFetch() to access temporary files in vdbesort.c. Use a single large allocation instead of many small allocations when accumulating records in vdbesort.c. This is an interim commit - it allocates a buffer the size of the page-cache every time data is sorted.
...
FossilOrigin-Name: f4ac1bf28c4ba395ccab8f1c9df72614a61095a7
2014-03-27 17:23:41 +00:00
382bdeabef
Enhance the logest.c utility with new operators: "dup", "inv", "log", and
...
"nlogn". Provide help on an invalid input.
FossilOrigin-Name: b4bd2a062c4baf5f622d61b7411f00de5904ef56
2014-03-27 14:05:38 +00:00
bfa463696b
Merge the latest trunk changes and the fix for the crash on a corrupt
...
database.
FossilOrigin-Name: 0b35346c32dba14963c85ec178f2b46aa2bbf6dc
2014-03-27 00:09:00 +00:00
664eb14d8e
Merge from trunk the fix for the crash on a corrupt database.
...
FossilOrigin-Name: 8cb2b02baa7ef9aa96319e977f0315328f944237
2014-03-26 19:45:01 +00:00
68916c9fd3
Add an extra test case for the potential buffer overread patched by [28ddecff04].
...
FossilOrigin-Name: f585f5d7a0f9bf8c590388654a3638231eba8892
2014-03-26 15:14:59 +00:00
dan